php -a
require 'src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php';
$asd = new PhabricatorMetaMTAReceivedMailProcessingException("1", "TEST MESSAGE");
var_dump($asd->getMessage());

You get:

string(12) "TEST MESSAGE"

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Mar 26 2023, 15:42

Owners added a reviewer: O1: Blessed Committers.Mar 26 2023, 15:42

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 26 2023, 15:42

valerio.bozzolan requested review of this revision.Mar 26 2023, 15:42

Harbormaster completed remote builds in B190: Diff 405.Mar 26 2023, 15:42

valerio.bozzolan edited the test plan for this revision. (Show Details)Mar 26 2023, 15:51

valerio.bozzolan added inline comments.Mar 26 2023, 15:57

src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php
17	The above line means that if you do this somewhere: new PhabricatorMetaMTAReceivedMailProcessingException( 'asd', 'lol' ); The above lines do this: parent::__construct( 'asd', 'lol' ); That for my case is: Exception::__construct( 'asd', 'lol' ); Note that `get_parent_class($this)` returns the word `Exception`.

valerio.bozzolan edited the test plan for this revision. (Show Details)Mar 26 2023, 16:06

valerio.bozzolan edited the test plan for this revision. (Show Details)Mar 26 2023, 18:06

valerio.bozzolan mentioned this in Z1: Phorge.

valerio.bozzolan added inline comments.Mar 27 2023, 05:19

src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php
18	In short using the string `'parent'` is deprecated. It was replaced with `get_parent_class($this)` that at runtime gives the parent, and it's the exact replacement.