Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster

Authored by aklapper on Aug 6 2023, 20:47.
Referenced Files
F357364: D25377.diff
Sat, Sep 23, 04:55
Unknown Object (File)
Thu, Sep 21, 06:47
Unknown Object (File)
Mon, Sep 4, 12:10
Unknown Object (File)
Mon, Sep 4, 08:51
Unknown Object (File)
Sun, Sep 3, 13:07
Unknown Object (File)
Aug 23 2023, 19:42
Unknown Object (File)
Aug 23 2023, 13:22
Unknown Object (File)
Aug 20 2023, 00:57



strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=customOAuthUrlencodeNull, ref.master=788098096e11, ref.customOAuthUrlencodeNull=4f0f2043b7e9), phorge(head=master, ref.master=226f3150933d)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/harbormaster/controller/HarbormasterStepEditController.php:142]

Closes T15592

Test Plan

Add a build step for an existing Harbormaster Build Plan, see that page New Step: Drydock: Run Command is correctly rendered at /harbormaster/step/new/1/HarbormasterDrydockCommandBuildStepImplementation/

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable