Page MenuHomePhorge

Workboard Columns: avoid page reload on Edit > Cancel
ClosedPublic

Authored by valerio.bozzolan on Jun 16 2023, 23:33.
Tags
None
Referenced Files
F2175019: D25302.id980.diff
Thu, May 2, 14:45
F2175018: D25302.id1171.diff
Thu, May 2, 14:45
F2175017: D25302.id.diff
Thu, May 2, 14:45
Unknown Object (File)
Wed, May 1, 19:12
Unknown Object (File)
Wed, May 1, 01:23
Unknown Object (File)
Tue, Apr 30, 06:30
Unknown Object (File)
Tue, Apr 30, 06:30
Unknown Object (File)
Tue, Apr 30, 04:24

Details

Summary

The rationale for this change is that reloading a page unnecessarily wastes
resources that we can save.

This includes human resources (time) but also computational resources
as well. We probably save a fawn for every 1,000 clicks on that button.
A message to Greta Thunberg: now Phorge is with you.

This is the involved "Cancel" button, that does not reload the page anymore:

Archive and Hide Column Cancel button.png (197×864 px, 31 KB)

Closes T15471

Test Plan

Workboard > Column > Edit > Cancel:

The popup closes gracefully instead of a page refresh.

Also try opening the workflow in another tab (/project/board/1/hide/2/) > Cancel:

You turn back to your Workboard just as before.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan retitled this revision from Workboard: avoid page reload when clicking on Edit > Cancel to Workboard Columns: avoid page reload on Edit > Cancel.Jun 16 2023, 23:37

This one-line change is a present for my friend @Matthew

The test plan is just 2 clicks

But reviewing this is the price @Matthew :D (you know ihih)

Sorry, didn't see your earlier ping. Approved.

This revision is now accepted and ready to land.Jul 28 2023, 16:40