Page MenuHomePhorge

Workboard Columns: avoid page reload on Edit > Cancel
ClosedPublic

Authored by valerio.bozzolan on Jun 16 2023, 23:33.
Tags
None
Referenced Files
F3342274: D25302.1743663058.diff
Wed, Apr 2, 06:50
F3339093: D25302.1743613830.diff
Tue, Apr 1, 17:10
F3332943: D25302.1743528808.diff
Mon, Mar 31, 17:33
F3328420: D25302.1743456603.diff
Sun, Mar 30, 21:30
F3326536: D25302.1743419563.diff
Sun, Mar 30, 11:12
F3320231: D25302.1743324722.diff
Sat, Mar 29, 08:52
F3319042: D25302.1743297093.diff
Sat, Mar 29, 01:11
F3310202: D25302.1743192092.diff
Thu, Mar 27, 20:01

Details

Summary

The rationale for this change is that reloading a page unnecessarily wastes
resources that we can save.

This includes human resources (time) but also computational resources
as well. We probably save a fawn for every 1,000 clicks on that button.
A message to Greta Thunberg: now Phorge is with you.

This is the involved "Cancel" button, that does not reload the page anymore:

Archive and Hide Column Cancel button.png (197×864 px, 31 KB)

Closes T15471

Test Plan

Workboard > Column > Edit > Cancel:

The popup closes gracefully instead of a page refresh.

Also try opening the workflow in another tab (/project/board/1/hide/2/) > Cancel:

You turn back to your Workboard just as before.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan retitled this revision from Workboard: avoid page reload when clicking on Edit > Cancel to Workboard Columns: avoid page reload on Edit > Cancel.Jun 16 2023, 23:37

This one-line change is a present for my friend @Matthew

The test plan is just 2 clicks

But reviewing this is the price @Matthew :D (you know ihih)

Sorry, didn't see your earlier ping. Approved.

This revision is now accepted and ready to land.Jul 28 2023, 16:40