Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan
ClosedPublic

Authored by aklapper on Aug 6 2023, 20:37.
Tags
None
Referenced Files
F2324131: D25376.1721743861.diff
Mon, Jul 22, 14:11
F2324126: D25376.1721743856.diff
Mon, Jul 22, 14:10
F2324013: D25376.1721743404.diff
Mon, Jul 22, 14:03
Unknown Object (File)
Sun, Jul 21, 16:59
Unknown Object (File)
Thu, Jul 18, 19:46
Unknown Object (File)
Thu, Jul 18, 00:17
Unknown Object (File)
Wed, Jul 17, 21:10
Unknown Object (File)
Wed, Jul 17, 20:40

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=customOAuthUrlencodeNull, ref.master=788098096e11, ref.customOAuthUrlencodeNull=4f0f2043b7e9), phorge(head=master, ref.master=226f3150933d)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php:106]

Closes T15591

Test Plan

Visit /harbormaster/plan/edit/form/default/. "Create Build Plan" page renders as expected.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested review of this revision.Aug 6 2023, 20:37
This revision is now accepted and ready to land.Aug 7 2023, 03:12