Fix NULL pointer exception from Calendar's homepage in some circumstances
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	valerio.bozzolan
	Nov 28 2022, 20:24

Description

I tried using the Phorge/Phabricator Calendar import feature related to Importing .ics URIs.

After importing specific events, for example from Google Calendar (bleah), it can happen that the Calendar's homepage becomes broken. This was the exception error shown to video:

Call to a member function getEventsBetween() on null

This NULL pointer is thrown since this method can return NULL and it needs proper checks when used:

PhabricatorCalendarEventQuery#newRecurrenceSet()

It seems this change was also fixed in 2019 by Wikimedia folks but never sent to upstream:

https://phabricator.wikimedia.org/rPHABd7744d7e9bd05d3117b1a128a95231a8ee148b5e

https://phabricator.wikimedia.org/T220241

We could evaluate if they had a different approach.

Revisions and Commits

rP Phorge
	D25060	rPdc558b5538cd Fix NULL pointer exception in some circumstances from Calendar's homepage

Related Objects
Search...

		Status	Assigned	Task
		Open	None	T15081 Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge
		Resolved	valerio.bozzolan	T15136 Fix NULL pointer exception from Calendar's homepage in some circumstances