Page MenuHomePhorge
Differential D25123

Fix a PHP 8.1 issue related to preg_match() and null subject
ClosedPublic
Actions

Authored by valerio.bozzolan on Apr 14 2023, 14:02.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 21, 04:06
Unknown Object (File)
Thu, Sep 7, 15:30
Unknown Object (File)
Thu, Sep 7, 13:18
Unknown Object (File)
Thu, Sep 7, 08:02
Unknown Object (File)
Mon, Sep 4, 11:22
Unknown Object (File)
Sun, Sep 3, 11:01
Unknown Object (File)
Sun, Sep 3, 09:25
Unknown Object (File)
Sat, Sep 2, 22:44
View All 29 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Reviewers
Matthew
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated"
T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo)
Commits
rARCf4a639944de4: Fix a PHP 8.1 issue related to preg_match() and null subject
Summary

This change fixes 'arc patch' in some circumstances.

Closes T15254

Test Plan

I was able to run "arc patch D25111" without issues

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Apr 14 2023, 14:02
Owners added a reviewer: O1: Blessed Committers.Apr 14 2023, 14:02
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptApr 14 2023, 14:02
valerio.bozzolan requested review of this revision.Apr 14 2023, 14:02
Harbormaster completed remote builds in B249: Diff 490.Apr 14 2023, 14:02
valerio.bozzolan retitled this revision from Fix a PHP 8.1 issue related to preg_match() and null subject This change fixes 'arc patch' in some circumstances. to Fix a PHP 8.1 issue related to preg_match() and null subject.Apr 14 2023, 14:04
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan updated this revision to Diff 491.Apr 14 2023, 14:05

enable xdebug to make lint happy

Harbormaster completed remote builds in B250: Diff 491.Apr 14 2023, 14:05
valerio.bozzolan mentioned this in T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).Apr 14 2023, 14:09
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan added a task: T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated".
valerio.bozzolan added a comment.Apr 14 2023, 18:37

Hi @Matthew - probably you will love this small and cute one that fix a PHP 8.1

Have a nice week-end

Matthew accepted this revision.Apr 14 2023, 18:45

LGTM

This revision is now accepted and ready to land.Apr 14 2023, 18:45
Closed by commit rARCf4a639944de4: Fix a PHP 8.1 issue related to preg_match() and null subject (authored by valerio.bozzolan). · Explain WhyApr 14 2023, 20:13
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rARCf4a639944de4: Fix a PHP 8.1 issue related to preg_match() and null subject.
valerio.bozzolan mentioned this in 2023 Week 2.Apr 14 2023, 20:14
valerio.bozzolan awarded a token.Apr 14 2023, 20:21
avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54
valerio.bozzolan mentioned this in Next Up (since Week 18).Apr 25 2023, 20:29

Revision Contents
Changeset List

PathSizePackages
src/
repository/
api/
2 linesO1: Blessed Committers

Diff 494

View Options

src/repository/api/ArcanistGitAPI.php

Loading...