Page MenuHomePhorge

Hide the "hidden" fields on custom form previews
ClosedPublic

Authored by 20after4 on Apr 24 2022, 18:19.
Tags
None
Referenced Files
F1393052: D25037.id430.diff
Tue, Feb 20, 21:31
F1390867: D25037.id92.diff
Tue, Feb 20, 12:18
F1390866: D25037.id.diff
Tue, Feb 20, 12:18
F1390855: D25037.id428.diff
Tue, Feb 20, 12:18
F1390847: D25037.id381.diff
Tue, Feb 20, 12:14
F1390846: D25037.id429.diff
Tue, Feb 20, 12:14
F1389846: D25037.diff
Tue, Feb 20, 08:36
Unknown Object (File)
Sat, Feb 17, 09:53

Details

Summary

Hide the "hidden" fields on custom form previews.

Before this change, Phabricator's custom form preview doesn't actually hide the
hidden fields, instead it shows them at 50% opacity. It looks cluttered and
doesn't provide a very useful "preview" at all.

This just hides some fields via CSS.

Cherry picked from:

https://phabricator.wikimedia.org/rPHABbba62cf5243538af9e37cc1211a01d247294f9f7

Upstream Task:

https://phabricator.wikimedia.org/T209743

Test Plan

Tested in Wikimedia's fork. I believe it results in better UX.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey subscribed.

I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.

This revision is now accepted and ready to land.Oct 28 2022, 10:28
In D25037#1857, @avivey wrote:

I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.

This revision is part of T15081.

Matthew requested changes to this revision.Dec 8 2022, 22:34

This does not land cleanly, please merge from master and re-submit.

matthew@Tower phorge % arc land
[2022-12-08 23:33:09] EXCEPTION: (PhutilBootloaderException) The phutil library 'phorge' has not been loaded! at [<arcanist>/src/init/lib/PhutilBootloader.php:199]
PHP Fatal error:  Uncaught exception 'PhutilBootloaderException' with message 'The phutil library 'phorge' has not been loaded!' in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php:199
Stack trace:
#0 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/moduleutils.php(5): PhutilBootloader->getLibraryRoot('phabricator')
#1 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(482): phutil_get_library_root('phabricator')
#2 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(317): PhutilErrorHandler::getLibraryVersions()
#3 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(300): PhutilErrorHandler::formatStacktrace(Array)
#4 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(417): PhutilErrorHandler::outputStacktrace(Array)
#5 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(282): PhutilErrorHandler::dispatchErrorMessage('exception', Object( in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php on line 199

Fatal error: Uncaught exception 'PhutilBootloaderException' with message 'The phutil library 'phorge' has not been loaded!' in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php:199
Stack trace:
#0 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/moduleutils.php(5): PhutilBootloader->getLibraryRoot('phabricator')
#1 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(482): phutil_get_library_root('phabricator')
#2 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(317): PhutilErrorHandler::getLibraryVersions()
#3 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(300): PhutilErrorHandler::formatStacktrace(Array)
#4 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(417): PhutilErrorHandler::outputStacktrace(Array)
#5 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(282): PhutilErrorHandler::dispatchErrorMessage('exception', Object( in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php on line 199
This revision now requires changes to proceed.Dec 8 2022, 22:34

(I accept also as O1 since somebody from O1 tried to land)

Hi @Matthew please undo your -1 so the author can land

(My previous notification is nonsense - sorry)

This revision is now accepted and ready to land.Mar 24 2023, 23:09

(In 3 days I will assume a "Yeah my friends please Land this for me")

valerio.bozzolan edited the test plan for this revision. (Show Details)

(In 3 days I will assume a "Yeah my friends please Land this for me")

  • As mentioned here ↑
  • since I trust the proposal user
  • since this is only a change in CSS
  • since this does not break anything
  • since I tried this in my local installation with arc patch D25037 and I like its result
  • since in CC there are 5 people

I will help the author to land this.

sgtm

I've run this:

./bin/celerity map