Hide the "hidden" fields on custom form previews
Needs RevisionPublic
Actions

Authored by 20after4 on Apr 24 2022, 18:19.

Details

Reviewers

Cigaryno
avivey
Matthew

Group Reviewers

Blessed Committers
O1: Blessed Committers

Maniphest Tasks

T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge

Summary

Cherry picked https://phabricator.wikimedia.org/rPHABbba62cf5243538af9e37cc1211a01d247294f9f7

Test Plan

This just hides some fields via css. Tested in Wikimedia's fork. I believe it results in better UX.

Diff Detail

Repository

rP Phorge

Branch

phorge.it (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 66
Build 66: arc lint + arc unit

Event Timeline

20after4 created this revision.Apr 24 2022, 18:19

Owners added a reviewer: O1: Blessed Committers.Apr 24 2022, 18:19

Herald added subscribers: Matthew, valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptApr 24 2022, 18:19

20after4 requested review of this revision.Apr 24 2022, 18:19

Harbormaster completed remote builds in B66: Diff 92.Apr 24 2022, 18:19

20after4 mentioned this in T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.Apr 24 2022, 18:39

20after4 added a task: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Cigaryno added a subscriber: Cigaryno.Sep 13 2022, 14:21

LGTM, we may also upstream more Wikimedia patches, per T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.

This revision is now accepted and ready to land.Oct 28 2022, 10:28

In D25037#1857, @avivey wrote:

I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.

This revision is part of T15081.

This does not land cleanly, please merge from master and re-submit.

matthew@Tower phorge % arc land
[2022-12-08 23:33:09] EXCEPTION: (PhutilBootloaderException) The phutil library 'phorge' has not been loaded! at [<arcanist>/src/init/lib/PhutilBootloader.php:199]
PHP Fatal error:  Uncaught exception 'PhutilBootloaderException' with message 'The phutil library 'phorge' has not been loaded!' in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php:199
Stack trace:
#0 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/moduleutils.php(5): PhutilBootloader->getLibraryRoot('phabricator')
#1 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(482): phutil_get_library_root('phabricator')
#2 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(317): PhutilErrorHandler::getLibraryVersions()
#3 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(300): PhutilErrorHandler::formatStacktrace(Array)
#4 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(417): PhutilErrorHandler::outputStacktrace(Array)
#5 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(282): PhutilErrorHandler::dispatchErrorMessage('exception', Object( in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php on line 199

Fatal error: Uncaught exception 'PhutilBootloaderException' with message 'The phutil library 'phorge' has not been loaded!' in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php:199
Stack trace:
#0 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/moduleutils.php(5): PhutilBootloader->getLibraryRoot('phabricator')
#1 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(482): phutil_get_library_root('phabricator')
#2 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(317): PhutilErrorHandler::getLibraryVersions()
#3 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(300): PhutilErrorHandler::formatStacktrace(Array)
#4 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(417): PhutilErrorHandler::outputStacktrace(Array)
#5 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(282): PhutilErrorHandler::dispatchErrorMessage('exception', Object( in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php on line 199

This revision now requires changes to proceed.Dec 8 2022, 22:34