Details
Details
- Reviewers
Cigaryno avivey Matthew - Group Reviewers
Blessed Committers O1: Blessed Committers - Maniphest Tasks
- T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge
This just hides some fields via css. Tested in Wikimedia's fork. I believe it results in better UX.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- phorge.it (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 66 Build 66: arc lint + arc unit
Event Timeline
Comment Actions
LGTM, we may also upstream more Wikimedia patches, per T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Comment Actions
I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.
Comment Actions
This does not land cleanly, please merge from master and re-submit.
matthew@Tower phorge % arc land [2022-12-08 23:33:09] EXCEPTION: (PhutilBootloaderException) The phutil library 'phorge' has not been loaded! at [<arcanist>/src/init/lib/PhutilBootloader.php:199] PHP Fatal error: Uncaught exception 'PhutilBootloaderException' with message 'The phutil library 'phorge' has not been loaded!' in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php:199 Stack trace: #0 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/moduleutils.php(5): PhutilBootloader->getLibraryRoot('phabricator') #1 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(482): phutil_get_library_root('phabricator') #2 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(317): PhutilErrorHandler::getLibraryVersions() #3 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(300): PhutilErrorHandler::formatStacktrace(Array) #4 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(417): PhutilErrorHandler::outputStacktrace(Array) #5 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(282): PhutilErrorHandler::dispatchErrorMessage('exception', Object( in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php on line 199 Fatal error: Uncaught exception 'PhutilBootloaderException' with message 'The phutil library 'phorge' has not been loaded!' in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php:199 Stack trace: #0 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/moduleutils.php(5): PhutilBootloader->getLibraryRoot('phabricator') #1 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(482): phutil_get_library_root('phabricator') #2 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(317): PhutilErrorHandler::getLibraryVersions() #3 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(300): PhutilErrorHandler::formatStacktrace(Array) #4 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(417): PhutilErrorHandler::outputStacktrace(Array) #5 /Users/matthew/PhpstormProjects/Phorge/arcanist/src/error/PhutilErrorHandler.php(282): PhutilErrorHandler::dispatchErrorMessage('exception', Object( in /Users/matthew/PhpstormProjects/Phorge/arcanist/src/init/lib/PhutilBootloader.php on line 199