Check if the comments are interesting - thanks for this Phorgi patchi that seems lovely

I'm still a bit shocked by how PHP is so weird. So:

Wow. 10 years of PHP, first time that I notice this

yuuuuuuup

yuuuup

Patch approved in 123123121231323μ asd

Yup and thanks that somebody already put "PHID" is the inline description.

Well done \o/

As said in https://we.phorge.it/D25931#25023 I think this is a sub-task of T15243. And in this specific case, very probably we don't want to log anything. So your report could be considered a regression caused by T15243.

Thanks my friend. I 100% understand the problem and I'm happy you shared the stack trace in the task and I'm happy about this test plan that helped me to reproduce,

arc diff

It seems H29 works lol. I've improved it a bit to do not trigger if the celerity map was already touched.

Yep thanks, I need my clipboard of the 12 of August 2024 to get back the "D25772" to copy-paste it here and attract hackers asd

You clearly hacked my account lol

(I cannot double-accept so only just one accept asd)

Uhm. Good points:

Makes sense thaanks, 0s seems also the documented default

Nice

(and well done Herald²)

(And well done Herald)

Marking as "probably my previous block is now nonsense - but still not reviewed sorry" asd

Uhm yes thanks

In D25912#24622, @aklapper wrote:

In D25912#24618, @valerio.bozzolan wrote:

P.S. maybe if the task number is very small (e.g. 2) maybe we can still allow that.

I'd prefer not to introduce non-obvious confusing behavior (sometimes it does, sometimes it doesn't?) to increase code (and testing) complexity for no good reason...

It works on my computer and it makes me feel like a happy Phorgi unicorn running in a Phorgi golden forest, whoa

Another good simple candidate GDPR-friendly:

(Feel free to copy-paste the downstream task in Phorge - so the lack of task is not used as blocking reason - maybe title "Allow to mitigate spammers from workboard bulk move" or something similar)

Uh interesting - good to know for the future. So at least the button Mark All Read here in F3271029 should be enabled for your case - as very minimal mitigation sub-task

The current workaround is to wait for a real notification, to then finally be able to click the Mark All Read.

It happened to me but only in Wikimedia Phabricator, there I had a notification counter in the top-bar, but with no unread messages in the related list

Thaanks - please wait 7 days + 1 hour + 1 second + 42 milliseconds before landing to attract more Pòkèmòn reviewers

(M is short for Mockup probably)

In T15450#16936, @Iniquity wrote:

I agree that an additional status is needed for closing when creating a task. Current statuses are not obvious

Uh! That's magic. Thanks avivey. Created here: H29 Phorge: add comment to remember "celerity map" - T15209

Ah, it also works on my computer but really not relevant, just the patch description was in line with my business expectations

This is EXACTLY the kind of serious-business patch description that should be mandatory in every Phorge patch to speedup code review. Thanks my friend. asd

Given the fact that the original comment from the kind @speck seems now fully satisfied, I think there are no problems to land this :) Thanks again to speck for that proposal ( https://we.phorge.it/D25022#768 ) - so, I flag that as "done" very boldly.

P.S. - useful snippet shared by Daimona from Wikimedia:

Increasing a bit the priority since this is feasible, simple to reproduce, and really frustrating in 2025.

P.S. welcome in the family of Trusted Contributors and feel free to escalate this question as a new task under Bug Reports and by marking this question as obsolete in case - thanks again

Thanks for the question. I will follow answers. BTW I've found the nuked link:

Thanksss

In the meanwhile I paste here a proposed alternative that may better reflect the current situation (no need to update the patch - since I guess this phrase will attract more changes):

I agree on discussing the removal of this phrase. I will wait the task, but my opinion is that it's a legacy phrase from a company that had better to do than fixing weird workflows based on Prototypes (and it had sense). But now it's a community and we already work on best effort on everything, including prototypes. Moreover that phrase does not reflect the current situation, since we triaged and fixed 6 bugs on the Calendar prototype Calendar (even if it should be un-prototyped one day) - and probably more evident already-reviewed patches.

That's a good question. In general in Phorge/Phabricator any archived thing is editable. So I would say no, that archiving a chat still allows to write a message. But maybe it should not generate notifications.

@Cigaryno does it work also applying this D25535 ? Thanks Cigaryno

(Premising that I'm affected by T15985 lol - unrelated)

I think this is the upstream bug report lol

In D25859#24307, @mainframe98 wrote:

Shall I just land this then?

Thanks