Page MenuHomePhorge

Added the Jxxx Monogram to Phame Post Tab Titles
Needs RevisionPublic

Authored by Ekubischta on Fri, Sep 24, 18:01.

Details

Reviewers
speck
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
T15050: Add Monograms to Phame Post Titles
Summary

This revision brings Phame Posts inline with other objects like Tasks, Revisions, Passphrase, etc. which all place the Monogram into the browser tab title

This improves useability of Phame Posts by making it easier to reference them in other parts of Phorge

Old Look

image.png (274×486 px, 13 KB)

New Look

image.png (298×515 px, 16 KB)

Test Plan

Made a post, saw the Monogram in the title

Diff Detail

Repository
rP Phorge
Branch
T15050_Add_Monogram_To_Phame_Title
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 46
Build 46: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Fri, Sep 24, 18:01
Ekubischta edited the summary of this revision. (Show Details)

lgtm - I compared to a few other views just to confirm this is the same approach for adding monogram to the title. Thanks!

This revision is now accepted and ready to land.Sat, Sep 25, 16:42

Thinking about this a little more it could be intentional for these to not have monograms displayed in the page title. Tasks, Revisions, etc. are more meant to be directed to internal users of the system while Phame blog posts may also be directed to external users where a monogram might be more confusing. What do you think?

speck requested changes to this revision.Sat, Sep 25, 16:50

Marking as request changes during discussion

This revision now requires changes to proceed.Sat, Sep 25, 16:50
In D25022#768, @speck wrote:

Thinking about this a little more it could be intentional for these to not have monograms displayed in the page title. Tasks, Revisions, etc. are more meant to be directed to internal users of the system while Phame blog posts may also be directed to external users where a monogram might be more confusing. What do you think?

That is a good point, and is also likely the reason why the URL's contain a friendly path

Maybe a larger discussion could be had around the use cases for Phame?

In other words, is there a large use case for Phame Readers to not be users of the Phorge instance in question.?

I added this revision because our use case really is internal (we use them for meeting notes, release notes, etc. where we like to link everything up)

Then maybe just show the monogram when logged in.

In D25022#774, @bekay wrote:

Then maybe just show the monogram when logged in.

That's a good idea - Let me work through that...