Differential D25022
Added the Jxxx Monogram to Phame Post Tab Titles Authored by Ekubischta on Sep 24 2021, 18:01. Tags Referenced Files
Details
This revision brings Phame Posts inline with other objects like Tasks, Revisions, Passphrase, etc. which all place the Monogram into the browser tab title This improves useability of Phame Posts by making it easier to reference them in other parts of Phorge Old Look  New Look  Made a post, be logged-in, saw the Monogram in the title (as usual in other apps like Maniphest). See same post as logged-out (or be a search engine), saw just the title (so your SEO consultant is still happy).
Diff Detail
Event TimelineComment Actions lgtm - I compared to a few other views just to confirm this is the same approach for adding monogram to the title. Thanks! Comment Actions Thinking about this a little more it could be intentional for these to not have monograms displayed in the page title. Tasks, Revisions, etc. are more meant to be directed to internal users of the system while Phame blog posts may also be directed to external users where a monogram might be more confusing. What do you think? Comment Actions That is a good point, and is also likely the reason why the URL's contain a friendly path Maybe a larger discussion could be had around the use cases for Phame? In other words, is there a large use case for Phame Readers to not be users of the Phorge instance in question.? I added this revision because our use case really is internal (we use them for meeting notes, release notes, etc. where we like to link everything up) Comment Actions Thank you for this patch. I also agree with @bekay since I'm also concerned about SEO. I tried to apply it.
Comment Actions Honestly, do you still like this Diff after all these compromises? :D If yes, feel free to comment the proposed change. If not, feel free to abandon. In both cases it was nice to discuss together. Comment Actions I updated this revision so the title will only show the monogram if the user is logged in However - I do wonder if this is necessary - For instance, the public instance of Phorge allows the viewer to view Maniphest tasks and Differential Revisions- These tasks and revisions, when displayed publicly, DO display the monogram Same is true for Ponder questions, etc. I don't really have an opinion either way - (on the Public side) but I wonder if, for consistency, we should just display the monogram here publicly as well Comment Actions (Premising that I'm affected by T15985 lol - unrelated) Seems very useful to logged-in users and seems to do not introduce any regressions in SEO stuff for blog posts and it works on my computer. Green light from me lol. Please wait 22 minutes + 22 seconds before landing, to attract more Linus eyeballs 👀 👀 👀
| ||||||||||||||||||||||||||||||||||||||||||||||||||
