Page MenuHomePhorge
Differential D25922

Fix invalid CSS cursor value for .phabricator-main-menu-brand
ClosedPublic
Actions

Authored by aklapper on Mon, Mar 24, 17:51.
Tags
None
Referenced Files
F3532266: D25922.1744890056.diff
Wed, Apr 16, 11:40
F3531971: D25922.1744888413.diff
Wed, Apr 16, 11:13
F3531964: D25922.1744888249.diff
Wed, Apr 16, 11:10
F3395864: D25922.1744518086.diff
Sat, Apr 12, 04:21
F3388596: D25922.1744447439.diff
Fri, Apr 11, 08:43
F3388592: D25922.1744447427.diff
Fri, Apr 11, 08:43
F3388589: D25922.1744447421.diff
Fri, Apr 11, 08:43
F3364787: D25922.1744160913.diff
Tue, Apr 8, 01:08
View All 21 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPfede9f450555: Fix invalid CSS cursor value for .phabricator-main-menu-brand
Summary

The W3C CSS validator throws Value Error : cursor hand is not a cursor value : hand.
hand is not a valid value for cursor; likely pointer was meant.
See https://developer.mozilla.org/en-US/docs/Web/CSS/cursor

Test Plan

Paste main-menu-view.css into https://jigsaw.w3.org/css-validator/ and read some CSS docs.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Mon, Mar 24, 17:51
Owners added a reviewer: O1: Blessed Committers.Mon, Mar 24, 17:51
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Mar 24, 17:51

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Mon, Mar 24, 17:51
Harbormaster completed remote builds in B1802: Diff 2771.Mon, Mar 24, 17:51
valerio.bozzolan accepted this revision.Tue, Mar 25, 08:19

sgtm

This revision is now accepted and ready to land.Tue, Mar 25, 08:19
Closed by commit rPfede9f450555: Fix invalid CSS cursor value for .phabricator-main-menu-brand. · Explain WhyTue, Mar 25, 09:25
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPfede9f450555: Fix invalid CSS cursor value for .phabricator-main-menu-brand.
aklapper mentioned this in Next Up.Tue, Mar 25, 09:41

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
application/
base/
2 linesO1: Blessed Committers

Diff 2773

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0