Page MenuHomePhorge

Replace some AphrontView::setUser() calls with AphrontView::setViewer()
Needs ReviewPublic

Authored by aklapper on Sat, Feb 15, 15:15.
Tags
None
Referenced Files
F2985668: D25880.1740078089.diff
Wed, Feb 19, 19:01
F2982842: D25880.1739971978.diff
Tue, Feb 18, 13:32
F2982742: D25880.1739971745.diff
Tue, Feb 18, 13:29
F2982503: D25880.1739961067.diff
Tue, Feb 18, 10:31
F2980192: D25880.1739878390.diff
Mon, Feb 17, 11:33
F2979405: D25880.1739852763.diff
Mon, Feb 17, 04:26
F2979400: D25880.1739852368.diff
Mon, Feb 17, 04:19
F2979394: D25880.1739851896.diff
Mon, Feb 17, 04:11

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

See rPaaab1011e5a464ea94c182001a7fe867b19bae5a.
AphrontView::setUser() is deprecated.
Save a few CPU cycles and nuclear power plants.

Test Plan

Read the code.
Even better, intentionally introduce an error in AphrontView::setUser()
and browse random Phorge pages and then replace the call accordingly (as
there are numerous setUser() methods across the codebase and we don't
want no explosions).

Diff Detail

Repository
rP Phorge
Branch
deprecateSetUser (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1706
Build 1706: arc lint + arc unit