Page MenuHomePhorge

Herald actions: Allow setting subtype on Maniphest tasks
AcceptedPublic

Authored by aklapper on Sat, Mar 22, 10:16.

Details

Summary

https://secure.phabricator.com/T12314 introduced task subtypes. Allow Herald rules which change/set the subtype of a task.
Code originally written by @20after4 for Wikimedia.

Closes T16022

Test Plan
  1. Have the default subtype configuration with three types under http://phorge.localhost/config/edit/maniphest.subtypes/ defined in src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
  2. Go to http://phorge.localhost/herald/edit/?content_type=HeraldManiphestTaskAdapter&rule_type=global
  3. Under "Action", select the new "Change subtype to" option. Test the subtype search by clicking the magnifier icon, set up a Herald rule to test execution.
  4. Remove the config for http://phorge.localhost/config/edit/maniphest.subtypes/
  5. Repeat step 3, no explosions, default "Task" subtype still exists after removing the config.

Diff Detail

Repository
rP Phorge
Branch
HeraldTaskSubtype (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1788
Build 1788: arc lint + arc unit

Event Timeline

It works on my computer and it makes me feel like a happy Phorgi unicorn running in a Phorgi golden forest, whoa

This revision is now accepted and ready to land.Sat, Mar 22, 21:40