page should log git errors instead of silently ignore them
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	valerio.bozzolan
	Apr 8 2023, 21:54

Description

The /config/ page should log git errors instead of silently ignore them.

I'm talking about this page:

Specific potentially problematic code:

list($err, $stdout) = $remote_future->resolve();
if ($err) {
  // If this fails for whatever reason, just move on.
  continue;
}

rP Phorge
	D25148	rP83edbffd521d Config page: add lovely git-related error messages in standard error log

Status	Assigned	Task
Open	None	T15090 CVE-2022-24765 - Multi-user Git Privilege Escalation
Open	valerio.bozzolan	T15282 Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'
Open	None	T15242 /config/ can run git log commands that silently fail ("fatal: detected dubious ownership in repository at ....")
Resolved	valerio.bozzolan	T15243 The /config/ page should log git errors instead of silently ignore them

valerio.bozzolan triaged this task as Normal priority.Apr 8 2023, 21:54

valerio.bozzolan created this task.

valerio.bozzolan created this object in space S1 Public.

Hi @aklapper can I ask you what do you see visiting the /config/ page of your installation?

You should see something like this:

But I wonder if you see "Unknown" somewhere

@valerio.bozzolan Uhm, you're right, I get Unknowns:

	F285035: Screenshot from 2023-04-30 01-37-47.png
	Apr 29 2023, 23:39