Page MenuHomePhorge
Differential D25923

Fix invalid CSS transition value for .jx-scrollbar-handle
ClosedPublic
Actions

Authored by aklapper on Mon, Mar 24, 17:56.
Tags
None
Referenced Files
F3532267: D25923.1744890144.diff
Wed, Apr 16, 11:42
F3532058: D25923.1744889734.diff
Wed, Apr 16, 11:35
F3531967: D25923.1744888312.diff
Wed, Apr 16, 11:11
F3531966: D25923.1744888302.diff
Wed, Apr 16, 11:11
F3498384: D25923.1744792163.diff
Tue, Apr 15, 08:29
F3440949: D25923.1744692012.diff
Mon, Apr 14, 04:40
F3388604: D25923.1744447467.diff
Fri, Apr 11, 08:44
F3388602: D25923.1744447456.diff
Fri, Apr 11, 08:44
View All 27 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPfcd6a4c28aba: Fix invalid CSS transition value for .jx-scrollbar-handle
Summary

The W3C CSS validator throws 0 is not a transition value : opacity 0 linear.
0 is not a valid value; likely 0s were meant as in other existing CSS definitions.
See https://developer.mozilla.org/en-US/docs/Web/CSS/transition

Test Plan

Paste standard-page-view.css into https://jigsaw.w3.org/css-validator/ and read some CSS docs.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Mon, Mar 24, 17:56
Owners added a reviewer: O1: Blessed Committers.Mon, Mar 24, 17:56
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Mar 24, 17:56

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Mon, Mar 24, 17:56
Harbormaster completed remote builds in B1803: Diff 2772.Mon, Mar 24, 17:56
valerio.bozzolan accepted this revision.Tue, Mar 25, 07:55

Makes sense thaanks, 0s seems also the documented default

This revision is now accepted and ready to land.Tue, Mar 25, 07:55
aklapper updated this revision to Diff 2774.Tue, Mar 25, 09:28

git rebase master

Harbormaster completed remote builds in B1804: Diff 2774.Tue, Mar 25, 09:28
Closed by commit rPfcd6a4c28aba: Fix invalid CSS transition value for .jx-scrollbar-handle. · Explain WhyTue, Mar 25, 09:29
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPfcd6a4c28aba: Fix invalid CSS transition value for .jx-scrollbar-handle.
aklapper mentioned this in Next Up.Tue, Mar 25, 09:41

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
application/
base/
8 linesO1: Blessed Committers

Diff 2775

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0