Paths

Table of Contentst

Differential D25943

PHPDoc: Replace non-existing return type phid with string
ClosedPublic
Actions

Authored by aklapper on Tue, Apr 1, 09:01.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC93930454c58a: PHPDoc: Replace non-existing return type phid with string

Summary

phid is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html.
Thus return string and get less errors reported by PHPStan.

Test Plan

Read docs; run static code analysis.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Apr 1, 09:01

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 1, 09:01

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 1, 09:01

aklapper requested review of this revision.Tue, Apr 1, 09:01

Harbormaster completed remote builds in B1836: Diff 2825.Tue, Apr 1, 09:01

yuuuuuuup

This revision is now accepted and ready to land.Tue, Apr 1, 18:23

Closed by commit rARC93930454c58a: PHPDoc: Replace non-existing return type phid with string. · Explain WhyTue, Apr 1, 23:15

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC93930454c58a: PHPDoc: Replace non-existing return type phid with string.

Revision Contents
Changeset List

Path

Size

Packages

src/

workflow/

ArcanistWorkflow.php

6 lines

O1: Blessed Committers

Diff 2828

src/workflow/ArcanistWorkflow.php

Loading...