Page MenuHomePhorge

Fix invalid CSS overflow value for .phui-oi-name
ClosedPublic

Authored by aklapper on Mon, Mar 24, 14:52.
Tags
None
Referenced Files
F3388587: D25921.1744447416.diff
Fri, Apr 11, 08:43
F3388583: D25921.1744447407.diff
Fri, Apr 11, 08:43
F3388577: D25921.1744447399.diff
Fri, Apr 11, 08:43
F3388574: D25921.1744447393.diff
Fri, Apr 11, 08:43
F3374876: D25921.1744298578.diff
Wed, Apr 9, 15:22
F3374834: D25921.1744297713.diff
Wed, Apr 9, 15:08
F3370843: D25921.1744234164.diff
Tue, Apr 8, 21:29
F3364786: D25921.1744160842.diff
Tue, Apr 8, 01:07

Details

Summary

The W3C CSS validator throws Value Error : overflow normal is not a overflow value : normal.
normal is not a valid value for overflow, as browsers currently cannot parse it they fall back to the default visible, thus change it to visible.
See https://developer.mozilla.org/en-US/docs/Web/CSS/overflow

Test Plan

Paste phui-oi-list-view.css into https://jigsaw.w3.org/css-validator/ and read some CSS docs.

Also, visit a page showing a PHUIObjectItemView, like the /phame/post/ page, and
have a object with a veeeeeery long name, and see absolutely no difference A/B,
both on desktop, medium and small screens.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

This revision is now accepted and ready to land.Fri, Mar 28, 10:18