Remove -khtml-opacity: 0.5; from CSS.
Per https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html, standard opacity has been supported since Safari 2.0 released in April 2005. If you still run Safari 1.x after 20 years you have bigger problems than this line of CSS in Phorge.
This is the only -khtml- prefixed property in the codebase.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP645b1f5a99a7: Remove pre-2005 vendor-prefixed -khtml- CSS property
None.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:
./bin/celerity map
⚙️ Thanks! Bip bop I'm a bot - helping for T15209
Comment Actions
Remove pre-2013 vendor-prefixed -moz- CSS properties
Summary:
Per https://caniuse.com/ and MDN,
- -moz-opacity superseded by unprefixed opacity supported since Firefox 2 released 10/2006
- -moz-border-radius superseded by unprefixed border-radius supported since Firefox 4 released 03/2011
- -moz-box-shadow superseded by unprefixed box-shadow supported since Firefox 4 released 03/2011
- -moz-animation superseded by unprefixed animation supported since Firefox 16 released 08/2012
- -moz-backface-visibility superseded by unprefixed backface-visibility supported since Firefox 16 released 08/2012
- @-moz-keyframes superseded by unprefixed @keyframes supported since Firefox 16 released 08/2012
- -moz-transform superseded by unprefixed transform supported since Firefox 16 released 08/2012
Test Plan:
None. Probably installing old browser versions if you don't trust documentation.
Comment Actions
Great, Phorge. So much for stacked patches... Looks like git checkout -b mozPrefixedCss cssKhtmlOpacity did not do what I had expected it to do.