Page MenuHomePhorge
Create Task
Maniphest T16023

Regression in Config: console generates errors when some libraries are not managed by Git
Closed, ResolvedPublic
Actions

Description

On the Phorge of WMGMC, we use a git repository for managing our fork but copy files into a OCI container image before deploying. Thus, .git is not available in our production environment.

However, /config/ generates errors when .git is not available:

Command failed with error #128!
COMMAND
git remote -v

STDOUT
(empty)

STDERR
fatal: not a git repository (or any of the parent directories): .git

Stack trace:
ExecFuture::raiseResultError called at [/opt/arcanist/src/future/exec/ExecFuture.php:341]
ExecFuture::resolvex called at [/opt/phorge/src/applications/config/controller/PhabricatorConfigConsoleController.php:193]
phlog called at [/opt/phorge/src/applications/config/controller/PhabricatorConfigConsoleController.php:373]
PhabricatorConfigConsoleController::logGitErrorWithPotentialTips called at [/opt/phorge/src/applications/config/controller/PhabricatorConfigConsoleController.php:195]
PhabricatorConfigConsoleController::loadVersions called at [/opt/phorge/src/applications/config/controller/PhabricatorConfigConsoleController.php:83]
PhabricatorConfigConsoleController::newLibraryVersionTable called at [/opt/phorge/src/applications/config/controller/PhabricatorConfigConsoleController.php:63]
PhabricatorConfigConsoleController::handleRequest called at [/opt/phorge/src/aphront/configuration/AphrontApplicationConfiguration.php:284]
AphrontApplicationConfiguration::processRequest called at [/opt/phorge/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
AphrontApplicationConfiguration::runHTTPRequest called at [/opt/phorge/webroot/index.php:35]

Revisions and Commits

rP Phorge
D25931rPa81f20e0f228 Config: Fix git errors when .git does not exist

Related Objects
Search...

Event Timeline

xtex created this task.Fri, Mar 28, 14:48
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptFri, Mar 28, 14:48
xtex added a revision: D25931: Config: Fix git errors when .git does not exist.Fri, Mar 28, 14:55
xtex mentioned this in D25931: Config: Fix git errors when .git does not exist.
valerio.bozzolan subscribed.Fri, Mar 28, 15:19
valerio.bozzolan added a comment.Fri, Mar 28, 15:41

Thanks

As said in https://we.phorge.it/D25931#25023 I think this is a sub-task of T15243. And in this specific case, very probably we don't want to log anything. So your report could be considered a regression caused by T15243.

So you may want to hack a bit this thing to completely suppress error logging for that specific exception (with a comment pointing to this task):

https://we.phorge.it/source/phorge/browse/master/src/applications/config/controller/PhabricatorConfigConsoleController.php$350

xtex added a commit: rPa81f20e0f228: Config: Fix git errors when .git does not exist.Fri, Mar 28, 15:59
valerio.bozzolan assigned this task to xtex.EditedFri, Mar 28, 16:00

Well done \o/

Tip: the "Closes T123" automagically closes things from commit message.

xtex closed this task as Resolved.Fri, Mar 28, 16:01

Thanks for the hint.

valerio.bozzolan renamed this task from Config console generates errors when some libraries are not managed by Git to Regression in Config: console generates errors when some libraries are not managed by Git.Fri, Mar 28, 16:02
valerio.bozzolan added a parent task: T15243: The /config/ page should log git errors instead of silently ignore them.
valerio.bozzolan awarded a token.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0