Differential D25901

ManiphestReportController: Add more PHPDoc coverage
ClosedPublic
Actions

Authored by aklapper on Mar 3 2025, 14:45.

Tags

None

Referenced Files

	F3361640: D25901.1744045501.diff
	Sun, Apr 6, 17:05

	F3361398: D25901.1744028779.diff
	Sun, Apr 6, 12:26

	F3360560: D25901.1744002175.diff
	Sun, Apr 6, 05:02

	F3358479: D25901.1743925127.diff
	Sat, Apr 5, 07:38

	F3355899: D25901.1743878174.diff
	Fri, Apr 4, 18:36

	F3343442: D25901.1743679896.diff
	Wed, Apr 2, 11:31

	F3318532: D25901.1743286477.diff
	Fri, Mar 28, 22:14

	F3300840: D25901.1743048958.diff
	Wed, Mar 26, 04:15

View All 35 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP0f4ab2413d8b: ManiphestReportController: Add more PHPDoc coverage

Summary

Make things a bit easier to understand, for the start.

Test Plan

Check return values for their types and classes.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Mar 3 2025, 14:45

Owners added a reviewer: O1: Blessed Committers.Mar 3 2025, 14:45

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 3 2025, 14:45

aklapper requested review of this revision.Mar 3 2025, 14:45

Harbormaster completed remote builds in B1760: Diff 2716.Mar 3 2025, 14:45

Thanks

sgtm

src/applications/maniphest/controller/ManiphestReportController.php
519	I don't like hardcoding it also in PHPDoc lol Maybe better to say that "greater means big priority" (or vice-versa - I don't know lol)

This revision is now accepted and ready to land.Mar 3 2025, 14:49

aklapper marked an inline comment as done.Mar 3 2025, 14:51

aklapper added inline comments.

src/applications/maniphest/controller/ManiphestReportController.php
519	The docs cover the current behavior. ;) I'll leave understanding Priority integers as an exercise to admins and developers if anyone ever wants to dig into that.

Closed by commit rP0f4ab2413d8b: ManiphestReportController: Add more PHPDoc coverage. · Explain WhyMar 3 2025, 14:53

This revision was automatically updated to reflect the committed changes.

aklapper marked an inline comment as done.

aklapper added a commit: rP0f4ab2413d8b: ManiphestReportController: Add more PHPDoc coverage.

valerio.bozzolan added inline comments.Mar 3 2025, 14:53

src/applications/maniphest/controller/ManiphestReportController.php
519	This is a nightmare for my dreams but I have already approved so... asd But better to explain what it is than to explain its current value

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

maniphest/

controller/

ManiphestReportController.php

42 lines

O1: Blessed Committers

Diff 2717

src/applications/maniphest/controller/ManiphestReportController.php

Loading...