fix corner case of NULL phid

In D25419#12006, @valerio.bozzolan wrote:

It seems your "master" branch has (many?) local unexpected commits.

In order to work on this feature, in Phorge, try these:

git status
# you should be on master - please eventually manually delete any local uncommitted change

Then, create another clean branch:

git branch   pippo_feature
git switch   pippo_feature
git reset --hard origin/master

So now you are on a custom branch pippo_feature that is super-clean. From there you can add fresh features and propose whatever patch.

(To switch between branches, just git switch master or git switch pippo_feature ecc.)

Updating D25419: Fix the whitespace issue in the message "Access Denied: Restricted File"

You're right valerio, this sign in is an automatic reflex since my Phorge instance is private ;)

It seems your "master" branch has (many?) local unexpected commits.

I kindly mark this as "request changes" since the author said that it needs an update to reflect the screenshot. Feel free to update with

Thanks Roberto, feel free to update D25420 to reflect your lovely screenshot.

Got it! Nice catch!

I'm thinking of adding similar handling for E_USER_NOTICE and E_USER_WARNING - to allow using them in extension code and in things like T15316 (Right now, we treat those as fatal errors too).

That works! Thank you!

Would taking care of the depreciations bump the minimum PHP version required to run Phorge?

Not in itself, but we do plan to bump the minimum to 7.1 (in T15047).

In T15626#13393, @valerio.bozzolan wrote:

Thanks I'm trying to reproduce. Can you please help me in understanding "click to the left next to the up arrow icon"? I probably don't get "click the left"

Interestingly I tried to open a simple README file and selecting UTF-8.

Thanks I'm trying to reproduce. Can you please help me in understanding "click to the left next to the up arrow icon"? I probably don't get "click the left"

sometimes i can not reproduce the issue

As this is broken anyway (and creates noisy log spam when someone tries to use the broken Create Identity form), would it make sense in the meantime as a workaround to disable (or hide, but no idea how to do that for a PhabricatorEditEngine) that form for every and any user? A one-line hack would be in P22.

Chrome 109 on Windows 7
No JS errors in console

Does not reproduce to me.
Which browser are you using? Are there any javascript errors?

Would taking care of the depreciations bump the minimum PHP version required to run Phorge?
looks good to me otherwise

Yeah, the dialog looks better then the extra notification...

I like so much this popup, thanks Roberto

In T15349#13341, @valerio.bozzolan wrote:

I don't know how to add a third button in a modal, but I would agree on that approach.

In D25416#11982, @valerio.bozzolan wrote:

Tested, seems good to me

To land, please do this from your side:

arc patch D25416
arc land

Thank you!

I don't know how to add a third button in a modal, but I would agree on that approach.

Tested, seems good to me

In D25374#10923, @Matthew wrote:

Please fix unit errors

fix lint

This seems the exact backward-compatible thing to me

Maybe we can improve the current popup from current:

But it adds another notification, and now the user will have to pick between 2 buttons that say "solve conflict".
It's also not the common path - in the common case, we expect users to actually approve the timezone offered by the dialog (which should be the one detected from the browser).

0. Welcome!

1. This diff is based of a commit that's not in master - some local changes that make it not-apply
2. the space should be on the inside of the pht(), not attached to it.
3. even better, find whatever is calling describeAutomaticCapability(), and if it accepts an array (some implementations return array, some return string), have the caller add a space between each element of the array - solving this once for all callers...

In D25420#11967, @avivey wrote:

Adding another notification will only make this more annoying.

Why not just improve the current dialog to make it easier to ignore the conflict?

Adding another notification will only make this more annoying.

Argh, sorry for my comment. I missed that rPbcfcd9acfc12fdf8ca3bf0e2c89651ba6d159b17 removed that noise already! (Anyway, I cannot share a stack trace when no stack trace is printed anyway.)

@aklapper Can you please share your stack trace?

@valerio.bozzolan: This is now spamming our error logs. Any recommendations how to proceed?

Thanks. I would like to help in reviewing but I don't get the difference. Can you describe the inline change?

Updating D25419: Fix the whitespace issue in the message "Access Denied: Restricted File"

Updating D25419: Fix the whitespace issue in the message "Access Denied: Restricted File"

fix a typo

Please do note that this patch is untested as I am unaware of reproduction steps.

Hi @bekay, I think that D25408 fixes this problem

shrug

Try again, after an rm and arc liberate on master, and then a git rebase master on this branch

and that's now wrong because src/__phutil_library_map__.php includes a non-existing file though I had ran git stash. I love git...

Obviously not a clean tree, sorry. Thus ran arc liberate, now arc asked whether to include unstaged changes in src/__phutil_library_map__.php (yes)