Page MenuHomePhorge

Fix RuntimeException: min(): Array must contain at least one element
ClosedPublic

Authored by aklapper on Aug 22 2023, 09:09.
Tags
None
Referenced Files
F358469: D25417.id1320.diff
Tue, Sep 26, 10:04
F358468: D25417.id1322.diff
Tue, Sep 26, 10:04
F358347: D25417.diff
Tue, Sep 26, 07:36
Unknown Object (File)
Fri, Sep 22, 14:00
Unknown Object (File)
Thu, Sep 21, 10:16
Unknown Object (File)
Wed, Sep 20, 18:11
Unknown Object (File)
Sat, Sep 16, 14:02
Unknown Object (File)
Sat, Sep 16, 12:48

Details

Summary

Make sure that $epochs[] is never empty but contains 0 so min($epochs) will not complain.

Closes T15623

Test Plan

Carefully read the code (as I am unaware of reproduction steps).

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Obviously not a clean tree, sorry. Thus ran arc liberate, now arc asked whether to include unstaged changes in src/__phutil_library_map__.php (yes)

and that's now wrong because src/__phutil_library_map__.php includes a non-existing file though I had ran git stash. I love git...

Try again, after an rm and arc liberate on master, and then a git rebase master on this branch

This revision is now accepted and ready to land.Aug 22 2023, 09:27