Page MenuHomePhorge

Fix RuntimeException: min(): Array must contain at least one element
ClosedPublic

Authored by aklapper on Aug 22 2023, 09:09.
Tags
None
Referenced Files
F3297620: D25417.1742987125.diff
Tue, Mar 25, 11:05
F3290562: D25417.1742868145.diff
Mon, Mar 24, 02:02
F3284542: D25417.1742778448.diff
Sun, Mar 23, 01:07
F3283704: D25417.1742757557.diff
Sat, Mar 22, 19:19
F3249243: D25417.1742285330.diff
Mon, Mar 17, 08:08
F3246610: D25417.1742212773.diff
Sun, Mar 16, 11:59
F3225164: D25417.1742094183.diff
Sat, Mar 15, 03:03
F3220088: D25417.1741800364.diff
Tue, Mar 11, 17:26

Details

Summary

Make sure that $epochs[] is never empty but contains 0 so min($epochs) will not complain.

Closes T15623

Test Plan

Carefully read the code (as I am unaware of reproduction steps).

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Obviously not a clean tree, sorry. Thus ran arc liberate, now arc asked whether to include unstaged changes in src/__phutil_library_map__.php (yes)

and that's now wrong because src/__phutil_library_map__.php includes a non-existing file though I had ran git stash. I love git...

Try again, after an rm and arc liberate on master, and then a git rebase master on this branch

This revision is now accepted and ready to land.Aug 22 2023, 09:27