Page MenuHomePhorge
Differential D25418

Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73
Needs ReviewPublic
Actions

Authored by aklapper on Aug 22 2023, 17:24.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 22, 23:47
Unknown Object (File)
Thu, Sep 21, 14:46
Unknown Object (File)
Sun, Sep 17, 12:38
Unknown Object (File)
Sat, Sep 16, 14:16
Unknown Object (File)
Sat, Sep 16, 08:05
Unknown Object (File)
Tue, Sep 12, 10:02
Unknown Object (File)
Mon, Sep 11, 12:43
Unknown Object (File)
Tue, Aug 29, 09:22
View All 9 Files
Subscribers
Cigaryno
Matthew
Sten
tobiaswiese
valerio.bozzolan

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15624: RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73
Summary

When given $encoding is invalid, catch the exception to show a proper error message and make the server logs provide more hints.

EXCEPTION: (RuntimeException) mb_convert_encoding(): Illegal character encoding specified at [<arcanist>/src/error/PhutilErrorHandler.php:261]
#0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<arcanist>/src/error/PhutilErrorHandler.php:261]
#1 <#2> mb_convert_encoding(string, string, string) called at [<phabricator>/src/applications/files/document/PhabricatorTextDocumentEngine.php:73]

Closes T15624

Test Plan

Unclear. Probably reading the code carefully.

Diff Detail

Repository
rP Phorge
Branch
T15624charenc (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 802
Build 802: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 22 2023, 17:24
Owners added a reviewer: O1: Blessed Committers.Aug 22 2023, 17:24
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 22 2023, 17:24
aklapper requested review of this revision.Aug 22 2023, 17:24
Harbormaster completed remote builds in B801: Diff 1325.Aug 22 2023, 17:24
aklapper added a comment.Aug 22 2023, 17:25

Please do note that this patch is untested as I am unaware of reproduction steps.

aklapper updated this revision to Diff 1326.Aug 22 2023, 17:27

fix a typo

Harbormaster completed remote builds in B802: Diff 1326.Aug 22 2023, 17:27
Sten subscribed.Fri, Sep 8, 08:35
Sten added inline comments.
src/applications/files/document/PhabricatorTextDocumentEngine.php
79

We get $message, but don't make use of it. Shouldn't we include $message in the log rather than. assuming it's an Illegal character encoding?

Also, should we set $this->encodingMessage to the error message?

Revision Contents
Changeset List

PathSizePackages
src/
applications/
files/
document/
16 linesO1: Blessed Committers

Diff 1326

View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...