Page MenuHomePhorge

Fix Exception in Chat room when you are not a Participant
ClosedPublic

Authored by valerio.bozzolan on Aug 18 2023, 08:55.
Tags
None
Referenced Files
F3980826: D25408.1746544027.diff
Mon, May 5, 15:07
F3980825: D25408.1746544011.diff
Mon, May 5, 15:06
F3980822: D25408.1746543964.diff
Mon, May 5, 15:06
F3980820: D25408.1746543909.diff
Mon, May 5, 15:05
F3946186: D25408.1746446529.diff
Sun, May 4, 12:02
F3946185: D25408.1746446528.diff
Sun, May 4, 12:02
F3896264: D25408.1746287504.diff
Fri, May 2, 15:51
F3877549: D25408.1746203817.diff
Thu, May 1, 16:36

Details

Summary

After this change you can lurk in public chats, and receive notifications, without crashing your planet.

Fix exception "Undefined index: PHID-USER-..." shown to newcomers when they are receiving messages
from a public Chat they are not members of.

Closes T15497

Test Plan

Now Alice does not see a crash anymore, but the message from Bob.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/conpherence/controller/ConpherenceUpdateController.php
378

Interestingly the page was already prepared to receive no participant. So the Diff is still consistent I hope.

speck subscribed.
speck added inline comments.
src/applications/conpherence/controller/ConpherenceUpdateController.php
344

Could you add a comment either here or above and reference the task? I think it will help in the future as it seems weird a user would be here but not be a participant.

This revision is now accepted and ready to land.Nov 8 2023, 23:17
valerio.bozzolan edited the test plan for this revision. (Show Details)