Page MenuHomePhorge
Differential D25571

T15774: Celerity: javascript minification issue with template literals (backticked strings)
Needs ReviewPublic
Actions

Authored by mturdus on Sun, Apr 7, 11:49.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 18:28
Unknown Object (File)
Wed, Apr 17, 07:15
Unknown Object (File)
Tue, Apr 16, 15:39
Unknown Object (File)
Tue, Apr 16, 06:30
F2142567: ext-D25571.tar.gz
Sun, Apr 14, 05:39
Unknown Object (File)
Sun, Apr 14, 04:47
Unknown Object (File)
Wed, Apr 10, 22:29
Unknown Object (File)
Wed, Apr 10, 16:36
View All 15 Files
Subscribers
aklapper
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Test Plan

This archive contains a small demo:

ext-D25571.tar.gz1 KBDownload

When installed, an application named D25571 appears under "More Applications".
When you start it, you will see 2 messageboxes: one should be a single lined text, the other a multilined text.

Steps:

  1. unpack archive in some directory
  2. add ext-D25571/src/ path to load-libraries in local.json
  3. bin/arc liberate
  4. bin/cache purge --all
  5. bin/celerity map
  6. restart httpd
  7. start D25571 application from More Applications

Diff Detail

Repository
rP Phorge
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1155
Build 1155: arc lint + arc unit

Event Timeline

mturdus created this revision.Sun, Apr 7, 11:49
Owners added a reviewer: O1: Blessed Committers.Sun, Apr 7, 11:49
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Apr 7, 11:49
mturdus requested review of this revision.Sun, Apr 7, 11:49
Harbormaster completed remote builds in B1155: Diff 1828.Sun, Apr 7, 11:49
mturdus retitled this revision from Summary: T15774. to T15774: Celerity: javascript minification issue with template literals (backticked strings).Sun, Apr 7, 11:51
aklapper subscribed.Sat, Apr 13, 17:46

Write Phorge application extension which uses backticked strings containing spaces.

"uses" in which way(s)? Is there a chance that you could provide some minimal, self-contained testcase?

Verify the javascript content from your extension.

How? Could you provide clearer steps that allow others to test this? Thanks a lot!

mturdus edited the test plan for this revision. (Show Details)Sun, Apr 14, 05:39

Revision Contents
Changeset List

PathSizePackages
externals/
JsShrink/
11 linesO1: Blessed Committers

Diff 1828

View Options

externals/JsShrink/jsShrink.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0