Add docs for color code formatting
Changes PlannedPublic
Actions

Authored by revi on Apr 30 2024, 08:42.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15871: Remarkup rule to show colors

Summary

Because there was no docs written at D25540, I opted to guess from the codes (and commit messages) to write it. (I admit I didn't test this RGB code thingy personally)

Ref T15871

Test Plan

Read the Docs (tm) and verify it renders.

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1207
Build 1207: arc lint + arc unit

Event Timeline

revi created this revision.Apr 30 2024, 08:42

Owners added a reviewer: O1: Blessed Committers.Apr 30 2024, 08:42

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 30 2024, 08:42

Harbormaster completed remote builds in B1207: Diff 1912.Apr 30 2024, 08:42

revi requested review of this revision.Apr 30 2024, 08:42

NOTE: ~~I will not have desktop access for next few days, so if you can just arc land it when you approve it, it'd be appreciated.~~

Just a question. Does it work for you? Since locally, {#FA8072} still does not work for me.

Also, I'm sincerely inclined in proposing this alternative syntax that would be super-stable:

D25540#16460

Haven't tested yet, I was just trying to document the patch behavior.

Or maybe what GitHub does might be of interest? (But also just my opinion)

This documentation is nice but unfortunately the feature introduced in 4d12d014fd9d never worked :( So documenting this as-is may create confusion, at the moment. Next steps:

T15871: Remarkup rule to show colors

Edited, I mean this task:

T15744: Render html color codes in remarkup

This revision now requires changes to proceed.Jun 30 2024, 13:08

valerio.bozzolan edited the summary of this revision. (Show Details)Jun 30 2024, 13:09

valerio.bozzolan added a task: T15871: Remarkup rule to show colors.

valerio.bozzolan mentioned this in T15744: Render html color codes in remarkup.Jun 30 2024, 13:12

removing from review queue until the underlying task discussion is settled.

(BTW, in D25698 we started deprecating remarkup.diviner for RemarkupReferenceController)