Page MenuHomePhorge

Drag & Drop: fix JavaScript error related to JX.$(undefined)
ClosedPublic

Authored by valerio.bozzolan on Apr 25 2023, 14:24.
Tags
None
Referenced Files
F3980695: D25134.1746541767.diff
Mon, May 5, 14:29
F3970180: D25134.1746526474.diff
Mon, May 5, 10:14
F3945776: D25134.1746445459.diff
Sun, May 4, 11:44
F3916371: D25134.1746353946.diff
Sat, May 3, 10:19
F3878243: D25134.1746219647.diff
Thu, May 1, 21:00
F3675918: D25134.1745531372.diff
Wed, Apr 23, 21:49
F3674051: D25134.1745485209.diff
Wed, Apr 23, 09:00
F3673810: D25134.1745480107.diff
Wed, Apr 23, 07:35

Details

Summary

This change fixes the following recent JavaScript error:

Error: Empty ID passed to JX.$()!

The regression was introduced here:

90f9da643d1622bcfff3a8903159aeefd1b42520

Closes T15272

Test Plan
  • with this change I was able to open Conpherence Persistent Chat and Drop a file

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan added a subscriber: Dylsss.

Thanks @Dylsss for any opinion about this small fix

This revision is now accepted and ready to land.Apr 26 2023, 06:51

I damn like avivey when runs like:

yesyes

The unit test was happy even if ./bin/celerity map was needed. Again.

jackie_chan_wtf

To find a scientific answer I will start debugging ./src/__tests__/PhabricatorCelerityTestCase.php in the future.