Page MenuHomePhorge

Drag & Drop: fix JavaScript error related to JX.$(undefined)
ClosedPublic

Authored by valerio.bozzolan on Apr 25 2023, 14:24.
Tags
None
Referenced Files
F2902151: D25134.1737297040.diff
Sat, Jan 18, 14:30
F2901536: D25134.1737281575.diff
Sat, Jan 18, 10:12
F2896266: D25134.1737240639.diff
Fri, Jan 17, 22:50
F2872042: D25134.1736878041.diff
Mon, Jan 13, 18:07
F2869466: D25134.1736707022.diff
Sat, Jan 11, 18:37
F2869438: D25134.1736705391.diff
Sat, Jan 11, 18:09
F2869436: D25134.1736705253.diff
Sat, Jan 11, 18:07
F2869431: D25134.1736704972.diff
Sat, Jan 11, 18:02

Details

Summary

This change fixes the following recent JavaScript error:

Error: Empty ID passed to JX.$()!

The regression was introduced here:

90f9da643d1622bcfff3a8903159aeefd1b42520

Closes T15272

Test Plan
  • with this change I was able to open Conpherence Persistent Chat and Drop a file

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan added a subscriber: Dylsss.

Thanks @Dylsss for any opinion about this small fix

This revision is now accepted and ready to land.Apr 26 2023, 06:51

I damn like avivey when runs like:

yesyes

The unit test was happy even if ./bin/celerity map was needed. Again.

jackie_chan_wtf

To find a scientific answer I will start debugging ./src/__tests__/PhabricatorCelerityTestCase.php in the future.