Page MenuHomePhorge

Drag & Drop: fix JavaScript error related to JX.$(undefined)
ClosedPublic

Authored by valerio.bozzolan on Apr 25 2023, 14:24.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 19:35
Unknown Object (File)
Mon, Mar 25, 06:45
Unknown Object (File)
Thu, Mar 21, 00:47
Unknown Object (File)
Mon, Mar 11, 21:18
Unknown Object (File)
Fri, Mar 8, 03:26
Unknown Object (File)
Feb 23 2024, 14:09
Unknown Object (File)
Feb 23 2024, 13:33
Unknown Object (File)
Feb 23 2024, 13:27

Details

Summary

This change fixes the following recent JavaScript error:

Error: Empty ID passed to JX.$()!

The regression was introduced here:

90f9da643d1622bcfff3a8903159aeefd1b42520

Closes T15272

Test Plan
  • with this change I was able to open Conpherence Persistent Chat and Drop a file

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan added a subscriber: Dylsss.

Thanks @Dylsss for any opinion about this small fix

This revision is now accepted and ready to land.Apr 26 2023, 06:51

I damn like avivey when runs like:

yesyes

The unit test was happy even if ./bin/celerity map was needed. Again.

jackie_chan_wtf

To find a scientific answer I will start debugging ./src/__tests__/PhabricatorCelerityTestCase.php in the future.