Paths

Table of Contentst

Differential D25634

Remove deprecated buildStandardPage* method calls
ClosedPublic
Actions

Authored by aklapper on May 11 2024, 14:33.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 24, 03:51

	Unknown Object (File)
	Wed, Jul 24, 03:51

	Unknown Object (File)
	Wed, Jul 24, 02:00

	Unknown Object (File)
	Tue, Jul 23, 20:31

	Unknown Object (File)
	Thu, Jul 18, 16:54

	Unknown Object (File)
	Sat, Jul 13, 09:30

	Unknown Object (File)
	Wed, Jul 10, 00:10

	Unknown Object (File)
	Tue, Jul 9, 20:28

View All 42 Files

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Commits

rPd5295da072ae: Remove deprecated buildStandardPage* method calls

Summary

Remove deprecated buildStandardPageView() and buildStandardPageResponse() methods.
They have been deprecated since rP300c74c49dc9d9f3ef1d7bbcc1b2400a3ded0c41 in November 2015.
cf rPd26cca27d70b69080c10e1df92a10419fffbfc7e, rP1b00ef08a039d48adb6bbbcd6956f900b6303b5b.

Test Plan

Compare http://phorge.localhost/xhpast/ before and after; paste and parse some PHP code into http://phorge.localhost/xhpast/; compare resulting http://phorge.localhost/xhpast/view/1/ before and after. Spot no differences and see no errors in DarkConsole.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.May 11 2024, 14:33

Owners added a reviewer: O1: Blessed Committers.May 11 2024, 14:33

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 11 2024, 14:33

Harbormaster completed remote builds in B1250: Diff 1975.May 11 2024, 14:33

aklapper requested review of this revision.May 11 2024, 14:33

aklapper edited the summary of this revision. (Show Details)May 11 2024, 14:36

avivey accepted this revision.May 11 2024, 14:48

This revision is now accepted and ready to land.May 11 2024, 14:48

Closed by commit rPd5295da072ae: Remove deprecated buildStandardPage* method calls. · Explain WhyMay 16 2024, 06:39

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPd5295da072ae: Remove deprecated buildStandardPage* method calls.

aklapper mentioned this in Z1: Phorge.Jun 3 2024, 18:40

aklapper mentioned this in Next Up.Jun 4 2024, 11:56

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

base/

controller/

PhabricatorController.php

21 lines

O1: Blessed Committers

phpast/

controller/

PhabricatorXHPASTViewController.php

14 lines

O1: Blessed Committers

PhabricatorXHPASTViewFrameController.php

13 lines

O1: Blessed Committers

Diff 1990

src/applications/base/controller/PhabricatorController.php

Loading...

src/applications/phpast/controller/PhabricatorXHPASTViewController.php

Loading...

src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php

Loading...