Page MenuHomePhorge

Add Standard Custom Fields to Item List
AcceptedPublic

Authored by avivey on Mar 1 2024, 16:26.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 23, 01:31
Unknown Object (File)
Mon, May 20, 18:10
Unknown Object (File)
Thu, May 16, 17:09
Unknown Object (File)
Wed, May 15, 16:43
Unknown Object (File)
Mon, May 13, 19:07
Unknown Object (File)
Sat, May 11, 11:25
Unknown Object (File)
Sat, May 4, 14:23
Unknown Object (File)
Sat, May 4, 14:23
Tokens
"Love" token, awarded by aklapper."Mountain of Wealth" token, awarded by 20after4.

Details

Summary

Allow "Standard" (config-based") custom fields to be displayed in search-results.

Depends on D25548. Ref T15750.

Test Plan

Set maniphest.custom-field-definitions to the value of P32, and start playing with custom values on tasks.

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25549
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1249
Build 1249: arc lint + arc unit

Event Timeline

avivey held this revision as a draft.
avivey edited the test plan for this revision. (Show Details)
avivey published this revision for review.Mar 1 2024, 16:48

Here's what it looks like with all the bells:

image.png (578×743 px, 63 KB)

If you're stylistically aligned, I'm sorry for this.

I'll test this locally, I can't see any reason we shouldn't merge it.

For some reasons I cannot cleanly apply the patch anymore.

I get:

error: while searching for:
    return $indexes;
  }

  public function renderPropertyViewValue(array $handles) {
    $value = $this->getFieldValue();

    if (!strlen($value)) {

error: patch failed: src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php:18

Uh! I like this.

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
376

I see that the addIcon() also supports a addIcon($value, $label) and it's nice.

Maybe useful to somehow expose that label.

This revision is now accepted and ready to land.Sat, May 18, 08:35