Details

error: while searching for:
    return $indexes;
  }

  public function renderPropertyViewValue(array $handles) {
    $value = $this->getFieldValue();

    if (!strlen($value)) {

error: patch failed: src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php:18

Rebase

Harbormaster completed remote builds in B1249: Diff 1974.May 11 2024, 10:48

Uh! I like this.

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
376	I see that the addIcon() also supports a `addIcon($value, $label)` and it's nice. Maybe useful to somehow expose that label.

This revision is now accepted and ready to land.May 18 2024, 08:35

avivey added inline comments.Jun 21 2024, 09:39

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
376	I think we can do that at a later date, by letting `list.icon` be either a simple string (icon name) or an object. I'll put a note in T15750 and in the code.

Closed by commit rP587530a9bf7b: Add Standard Custom Fields to Item List. · Explain WhyJun 21 2024, 09:45

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rP587530a9bf7b: Add Standard Custom Fields to Item List.

avivey mentioned this in Next Up.Jun 21 2024, 09:48

Add Standard Custom Fields to Item List
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2132

src/docs/user/configuration/custom_fields.diviner

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBlueprints.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Add Standard Custom Fields to Item ListClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2132

src/docs/user/configuration/custom_fields.diviner

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBlueprints.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Add Standard Custom Fields to Item List
ClosedPublic
Actions

Revision Contents
Changeset List