Page MenuHomePhorge
Differential D25549

Add Standard Custom Fields to Item List
Needs ReviewPublic
Actions

Authored by avivey on Mar 1 2024, 16:26.
Tags
None
Referenced Files
F2167134: D25549.diff
Sat, Apr 27, 16:23
Unknown Object (File)
Thu, Apr 25, 22:50
Unknown Object (File)
Thu, Apr 25, 22:50
Unknown Object (File)
Thu, Apr 25, 22:49
Unknown Object (File)
Thu, Apr 25, 22:49
Unknown Object (File)
Thu, Apr 25, 17:01
Unknown Object (File)
Fri, Apr 19, 06:16
Unknown Object (File)
Wed, Apr 17, 18:25
View All 34 Files
Subscribers
20after4
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan
Tokens
"Love" token, awarded by aklapper."Mountain of Wealth" token, awarded by 20after4.

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15750: Integrate CustomField into more interfaces
Summary

Allow "Standard" (config-based") custom fields to be displayed in search-results.

Depends on D25548. Ref T15750.

Test Plan

Set maniphest.custom-field-definitions to the value of P32, and start playing with custom values on tasks.

Diff Detail

Repository
rP Phorge
Branch
custom-list-2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1090
Build 1090: arc lint + arc unit

Event Timeline

avivey created this revision.Mar 1 2024, 16:26
avivey held this revision as a draft.
Owners added a reviewer: O1: Blessed Committers.Mar 1 2024, 16:26
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 1 2024, 16:26
Harbormaster completed remote builds in B1087: Diff 1733.Mar 1 2024, 16:26
avivey updated this revision to Diff 1735.Mar 1 2024, 16:36

cleanups

Harbormaster completed remote builds in B1089: Diff 1735.Mar 1 2024, 16:36
avivey edited the summary of this revision. (Show Details)Mar 1 2024, 16:41
avivey edited the test plan for this revision. (Show Details)
avivey added a task: T15750: Integrate CustomField into more interfaces.
avivey updated this revision to Diff 1736.Mar 1 2024, 16:45

lint

Harbormaster completed remote builds in B1090: Diff 1736.Mar 1 2024, 16:45
avivey published this revision for review.Mar 1 2024, 16:48

Here's what it looks like with all the bells:

image.png (578×743 px, 63 KB)

If you're stylistically aligned, I'm sorry for this.

20after4 subscribed.Mar 2 2024, 11:36

This is really cool!

20after4 awarded a token.Mar 2 2024, 11:36
aklapper awarded a token.Mar 3 2024, 10:15
avivey mentioned this in Z1: Phorge.Sat, Mar 30, 10:44
20after4 added a comment.Tue, Apr 2, 19:22

I'll test this locally, I can't see any reason we shouldn't merge it.

Revision Contents
Changeset List

Diff 1736

View Options

src/docs/user/configuration/custom_fields.diviner

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBlueprints.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0