Page MenuHomePhorge
Differential D25646

Correct rendering of workboard column move feed stories when a single transaction performs moves on multiple boards
ClosedPublic
Actions

Authored by aklapper on May 16 2024, 10:55.
Tags
None
Referenced Files
F3776536: D25646.1745863765.diff
Sun, Apr 27, 18:09
F3763824: D25646.1745840056.diff
Sun, Apr 27, 11:34
F3762717: D25646.1745835332.diff
Sun, Apr 27, 10:15
F3726971: D25646.1745726218.diff
Sat, Apr 26, 03:56
F3526708: D25646.1744832110.diff
Tue, Apr 15, 19:35
F3409125: D25646.1744599725.diff
Sun, Apr 13, 03:02
F3389632: D25646.1744459709.diff
Fri, Apr 11, 12:08
F3387353: D25646.1744436077.diff
Fri, Apr 11, 05:34
View All 46 Files
Subscribers
avivey
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Commits
rPc769125e9070: Correct rendering of workboard column move feed stories when a single…
Summary

If a single transaction performs column moves on multiple different boards (which is permitted in the API), the rendering logic in the feed currently fails. Make it render properly.

Same fix as rPa3f4cbd7484b591425e83bbfc7642bccb04d0d57 for getTitle() which left out also fixing getTitleForFeed().

Test Plan

Carefully read the if/else logic.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
src/
applications/
transactions/
storage/
2 linesO1: Blessed Committers

Diff 2161

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0