Page MenuHomePhorge
Differential D25729

Remove unreachable return statement in AphrontFormDateControlValue
ClosedPublic
Actions

Authored by aklapper on Jul 10 2024, 13:25.
Tags
None
Referenced Files
F3335334: D25729.1743561291.diff
Tue, Apr 1, 02:34
F3330189: D25729.1743484975.diff
Mon, Mar 31, 05:22
F3329938: D25729.1743482099.diff
Mon, Mar 31, 04:34
F3324770: D25729.1743404346.diff
Sun, Mar 30, 06:59
F3322076: D25729.1743363611.diff
Sat, Mar 29, 19:40
F3300626: D25729.1743044085.diff
Wed, Mar 26, 02:54
F3299865: D25729.1743029505.diff
Tue, Mar 25, 22:51
F3297107: D25729.1742981596.diff
Tue, Mar 25, 09:33
View All 32 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Commits
rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue
Summary

Two unconditional return statements lead to never reaching the second one.

Test Plan

Read the code of this method.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
src/
view/
form/
control/
2 linesO1: Blessed Committers

Diff 2238

View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0