Differential D25663

PHPMailer: Remove check for non-existing get_magic_quotes()
ClosedPublic
Actions

Authored by aklapper on May 18 2024, 23:12.

Tags

None

Referenced Files

	F3297354: D25663.1742984234.diff
	Tue, Mar 25, 10:17

	F3285875: D25663.1742809136.diff
	Sun, Mar 23, 09:38

	F3283918: D25663.1742762158.diff
	Sat, Mar 22, 20:35

	F3251815: D25663.1742376499.diff
	Tue, Mar 18, 09:28

	F3250299: D25663.1742299292.diff
	Mon, Mar 17, 12:01

	F3249531: D25663.1742286482.diff
	Mon, Mar 17, 08:28

	F3216827: D25663.1741716494.diff
	Mon, Mar 10, 18:08

	F3178730: D25663.1741312573.diff
	Thu, Mar 6, 01:56

View All 20 Files

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Commits

rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes()

Summary

No idea if PHP ever offered such a method. In any case, this very check was removed in https://github.com/PHPMailer/PHPMailer/commit/6f919df65e80023fce4eab58832b6035b4a41935#diff-2d294eae28fb0d70fc32da8369c4fe33d301c99ca3eeb4bd41da18ad99344d68 in 2012.

Test Plan

Not sure - how to test a removed check for a method which does not exist anyway? :)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.May 18 2024, 23:12

Owners added a reviewer: O1: Blessed Committers.May 18 2024, 23:12

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 18 2024, 23:12

Harbormaster completed remote builds in B1288: Diff 2026.May 18 2024, 23:12

aklapper requested review of this revision.May 18 2024, 23:12

avivey accepted this revision.May 19 2024, 06:06

This revision is now accepted and ready to land.May 19 2024, 06:06

aklapper retitled this revision from PHPMailer: Remove check for non-existing `get_magic_quotes` to PHPMailer: Remove check for non-existing get_magic_quotes().May 19 2024, 08:19

Closed by commit rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes(). · Explain WhyMay 19 2024, 08:20

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes().

Revision Contents
Changeset List

Path

Size

Packages

externals/

phpmailer/

class.phpmailer-lite.php

5 lines

O1: Blessed Committers

class.phpmailer.php

5 lines

O1: Blessed Committers

Diff 2028

externals/phpmailer/class.phpmailer-lite.php

Loading...

externals/phpmailer/class.phpmailer.php

Loading...