Just a question. Why under differential and not related to Remarkup?

Nice catch

Hi all, can this be approved if no one has any objections? Dashboards simply can't be modified under PHP 8.1 without this. Thanks.

In theory this could be a two-liner: Changing the last character of the $prefix, and in PhabricatorCursorPagedPolicyAwareQuery.php

- $map[$field->getFieldKey()] = $field->getValueForStorage();
+ $map[$field->getModernFieldKey()] = $field->getValueForStorage();

In practice that leads to: Unhandled Exception ("PhutilTypeExtraParametersException") - Got unexpected parameters: customfield, customfield.index.table, customfield.index.key

Did some digging, and it looks like Segoe is not something we can use:

Here is the homepage feed after I created this task. Nothing indicates that there was a task creation, just a triage:

Content is not in something, rather it's licensed under.

This is now resolved.

Thanks @aklapper, feel free to edit the Task description according to your proposal.

Nice catch. I agree that we should allow to have texts like asd {{{ lol }}} whey without any nuclear implosion needed by design just because we are trying to give support to cowsay or figlet.

<tl;dr>: This is a mismatch between legacy field keys still used for paging, versus modern field keys.

Add back code which shouldn't be removed.

Fix linting warnings.

Shorten too long line

Simplify code with neat functions as proposed by Valerio

Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) and Apache 2.0 unless otherwise noted.

In T15322#11590, @valerio.bozzolan wrote:

This would also help Wikimedia volunteers to upload screenshots of Phorge to Wikimedia Commons, avoiding annoying deletion procedures for the lack of the license in the very same page etc.

Nuance has a "GitHub Repository: Import issues and pull requests from a GitHub repository" Source Type - it might already be doing something related?

LGTM! :D

hey, @ton - is this useful for you?

yeah, just default to https if it doesn't include a schema, and I think it should be fine in that regards.
There's probably already some method somewhere that looks at a uri and chooses HTTPFuture or HTTPSFuture based on the schema...

I'm guessing this would break existing configurations. (Or we could detect if the endpoint contains the schema and prepend https:// only if it doesn't - for backwards compatibility).

• rollback CSS change

Better now?

• integrate tips from reviewers

Just to inform that maybe a sub-task bug report will be created soon. Related discussion: https://phabricator.wikimedia.org/T333885#9132176

(I accepted but before landing please first review all not-done inline comments: https://we.phorge.it/differential/revision/inlines/25420/ and this comment: https://we.phorge.it/D25420#12264 )

In D25420#12264, @waldyrious wrote:

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

• Instead of "You can ignore this conflict or adjust your profile setting to match your client", we should use the same order in the sentence as the options are shown to the user: "You can adjust your profile setting to match your client, or ignore this conflict."
• The label for the checkbox should be just "Ignore Conflict", without the "Or" at the start.
• When the "Ignore Conflict" checkbox is selected, the timezone dropdown should be disabled (and re-enabled if the checkbox is unmarked)

Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".

In D25425#12230, @valerio.bozzolan wrote:

maybe in the future we can have a CSS selector to be applied just to the "phorge/" pathname, in order to avoid mouse selection, and select just the command.