PhabricatorFileAttachmentQuery seems to eagerly load the object relation, however since the DestructionEngine extensions run after the object is already deleted, this fails and nothing is returned in the query. Changed to LiskDAO loadAllWhere, which also seems to use less queries in general (due to not eagerly loading), so changed the query in PhabricatorFile as well. Changed mpull to foreach per suggestion.

Decreasing just a bit the priority since we are a bit confused about how to proceed but feel free to change

It could also be some bots sending you fuzzy input. Consider to mark as invalid, until a real human being elevates this as a problem affecting some workflows.

Note that the upstream solution from Phabricator does not fix your problem, since

Are you aware of any non-git repository in Wikimedia?

Kindly marking as "request changes" only to indicate "waiting for author feedback"

Commit fixup/update author details

Organised attachment deletion from the file side into the File object and deletion from the object side into the destruction engine extension. Also updated the SQL patch date in the file name.

Without a reproduction, this is speculative.

Why would a branch name be an integer and not a string?

Looks like this created a regression: T15639: Exception: Value passed to "phutil_string_cast()" is an array in PhabricatorApplicationSearchEngine.php

Fixed my dirty tree, sorry

In D25066#8893, @valerio.bozzolan wrote:

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

I like it but I haven't tested locally.

Yeah, I generally agree with "let the user set the width of the page"...

Thanks Eyal for the quick answer.

Update unit test

Updates as per reviews

Add a note about figlet

Can you add a couple of tests to https://we.phorge.it/source/arcanist/browse/master/src/utils/__tests__/cowsay/ ?

I'm talking about Herald Webhook, not Herald Rule. So you can write some web code that is visited when something happens, so you can run custom code when that happens, and you can edit your Tasks.

Thanks for the Answer @valerio.bozzolan.
I have created those checklists as custom fields. The problem I have is all these lists are shown in all types of tickets and statuses.
But later with this checklist, I want to control the the status transition.
Eg: Only when "Checklist 1" and "Checklist 2" are selected, User should be able to change the status from In progress - Ready for testing.

Seems like it is solvable via

I tried to test this but I have not a real JIRA account and I was not able to test a non-null value. But, I inspected all the definitions of that method and it seems it only returns pht() so I would assume that it only returns strings.

I think this is apparently unrelated to projects. It's just needed to edit something else, keeping the date field as empty.

Tested. Thanks!

What do you think about the related tip? Also here I can maybe try to propose a counter-patch next week

What do you think about? Maybe I can try to propose a counter-patch about the related tip

Please wait 2-3 days before landing, so other people can share useful tips

Yeah why not, thanks

comments more sexier for reviewers

Updated differential_faq.diviner as per review.

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

Nice! Just few inline tips

While it could be nice to have this, in the meanwhile I think that having something minimal like D25434 would be nice

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

In D25434#12399, @valerio.bozzolan wrote:

lol

Just a question. Why under differential and not related to Remarkup?