Error handling: send Deprecation messages as explicit Event
d343be59269a
Actions

Description

Error handling: send Deprecation messages as explicit Event

Summary:
Ref T15554. When a deprecation warning is captured here, mark it as such and send using the same channel as error messages.
Error Handlers will generally ignore it now, so they'll need to be updated, e.g. D25386

Test Plan:
Hitting a strlen(null) before This Change:

Web:
- PhutilAggregateException - white boxes with red border.
Daemons:
- trace in daemon log, task fails. Daemon sleeps for 5 seconds.
Arcanist and Scripts in phorge/bin/ and phorge/scripts:
- execution blows up with error trace.
SSH server-side scripts (ssh-auth and ssh-exec):
- trace in configured log, execution fails
SSH client-side scripts (ssh-connect):
- execution blows up with error trace.

After this change:

Web:
- Before D25386: Nothing on screen, errors show in log.
- With D25386: logs + dark console.
Daemons:
- trace in daemon log, task completes successfully.
Arcanist and Scripts in phorge/bin/ and phorge/scripts/ :
- Error trace printed to STDERR, execution continues.
SSH server-side scripts (ssh-auth and ssh-exec):
- trace in configured log, execution continues.
SSH client-side scripts (ssh-connect):
- Error trace printed to STDERR, execution continues.