Page MenuHomePhorge

Fix call to undefined method PhutilJSON::encodeAsObject()
ClosedPublic

Authored by aklapper on Aug 14 2023, 20:56.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 11:30
Unknown Object (File)
Sat, Jun 15, 11:30
Unknown Object (File)
Sat, Jun 15, 10:38
Unknown Object (File)
Sat, Jun 15, 09:57
Unknown Object (File)
Wed, Jun 12, 08:07
Unknown Object (File)
Tue, Jun 11, 22:30
Unknown Object (File)
Tue, Jun 11, 10:09
Unknown Object (File)
Mon, Jun 10, 06:52

Details

Summary

Replace call to undefined method PhutilJSON::encodeAsObject() with existing PhutilJSON::encodeFormatted()

EXCEPTION: (Error) Call to undefined method PhutilJSON::encodeAsObject() at [<phabricator>/src/applications/transactions/xaction/PhabricatorEditEngineDefaultTransaction.php:68]

Closes T15603

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks for this. I need a double-check since I'm quite scared by the background of this root problem but fortunately this seems to have just one occurrence, the one you are fixing.

The origin seems this:

https://secure.phabricator.com/D20595

And this in particular:

https://secure.phabricator.com/D20594

Also let's verify XSS and this kind of stuff

Thanks for this change that looks absolutely reasonable.

Please wait a $random_amount_of_time (more than 1 second and less than 1 month) before landing this so we can attract more professssssssional opinions

This revision is now accepted and ready to land.Aug 15 2023, 07:30