Cowsay is great, but what if you want to talk like a koala?
This diff adds diviner documentation on how to use the additional templates in externals/cowsay/cows/
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP91faf16cace9: Add documentation for cowsay
bin/diviner generate
https://my.phorge.site/book/phorge/article/differential_cowsay/
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
___________________________
< Please approve this diff! >
---------------------------
\ . .
\ / `. .' "
\ .---. < > < > .---.
\ | \ \ - ~ ~ - / / |
_____ ..-~ ~-..-~
| | \~~~\.' `./~~~/
--------- \__/ \__/
.' O \ / / \ "
(_____, `._.' | } \/~~~/
`----. / } | / \__/
`-. | / | / `. ,~~|
~-.__| /_ - ~ ^| /- _ `..-'
| / | / ~-. `-. _ _ _
|_____| |_____| ~ - . _ _ _ _ _>
Comment Actions
Yes, that would be better. And then add links to from the differential guide. Watch this space...
Comment Actions
Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation
Comment Actions
Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation
Comment Actions
Nice! Just few inline tips
| src/docs/user/userguide/differential_faq.diviner | ||
|---|---|---|
| 54 | (Double space here) | |
| 56–57 | We can put "." at the end of the phrase. -Phabricator Also maybe taking inspiration from remarkup.diviner: -"similar to Markdown" | |
| src/docs/user/userguide/remarkup_cowsay.diviner | ||
| 18–27 | Maybe we can just render the thing, quoted. Example: > cowsay{{{Great work!}}} | |
| 35–48 | Also here, maybe we can just quote and render > cowsay(cow='tux'){{{Great work!}}} | |
Comment Actions
Updated differential_faq.diviner as per review.
I disagree with using cowsay to render the output to show what cowsay should generate for the following reasons:
- This would remove the demonstration of what the output looks like when the document is read as plain text - a primary purpose of markdown is that you can read the document directly, you don't have to view a rendered version over the web.
- If there was a fault, you wouldn't know what it's supposed to generate.
Comment Actions
Yeah why not, thanks
Please wait 2-3 days before landing, so other people can share useful tips
Comment Actions
Please wait 2-3 days before landing, so other people can share useful tips
Sure thing - I'll leave it till after 14th September.
Any suggestions or additions, bring it on!
_______________________
( Documentation is cool )
-----------------------
o
o
.--.
|o_o |
|:_/ |
// \ \
(| | )
/'\_ _/`\
\___)=(___/