Page MenuHomePhorge

Fix Diviner strlen(null) error when clicking on a link
ClosedPublic

Authored by Sten on Tue, Sep 5, 16:05.
Tags
None
Referenced Files
F358385: D25433.id1376.diff
Tue, Sep 26, 08:27
F358384: D25433.id1370.diff
Tue, Sep 26, 08:26
F358306: D25433.diff
Tue, Sep 26, 06:45
Unknown Object (File)
Sun, Sep 24, 14:38
Unknown Object (File)
Thu, Sep 21, 12:07
Unknown Object (File)
Thu, Sep 21, 06:51
Unknown Object (File)
Thu, Sep 21, 05:31
Unknown Object (File)
Wed, Sep 20, 14:46

Details

Summary

Fix issue whereby clicking on a link in Diviner (eg https://my.phorge.site/diviner/find/?name=Differential_User_Guide&type=article&jump=1) results in a strlen(null) error under PHP 8.1

Fixes T15635

Test Plan
  • Go into the Diviner differential page /book/phorge/article/differential/
  • Click on the link to Differential User Guide: Inline Comments

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten requested review of this revision.Tue, Sep 5, 16:05

Thaaanks

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

This revision is now accepted and ready to land.Wed, Sep 6, 10:45