Differential D25433

Fix Diviner strlen(null) error when clicking on a link
ClosedPublic
Actions

Authored by Sten on Tue, Sep 5, 16:05.

Tags

None

Referenced Files

	F358385: D25433.id1376.diff
	Tue, Sep 26, 08:27

	F358384: D25433.id1370.diff
	Tue, Sep 26, 08:26

	F358306: D25433.diff
	Tue, Sep 26, 06:45

	Unknown Object (File)
	Sun, Sep 24, 14:38

	Unknown Object (File)
	Thu, Sep 21, 12:07

	Unknown Object (File)
	Thu, Sep 21, 06:51

	Unknown Object (File)
	Thu, Sep 21, 05:31

	Unknown Object (File)
	Wed, Sep 20, 14:46

View All 13 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1

Commits

rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link

Summary

Fix issue whereby clicking on a link in Diviner (eg https://my.phorge.site/diviner/find/?name=Differential_User_Guide&type=article&jump=1) results in a strlen(null) error under PHP 8.1

Fixes T15635

Test Plan

Go into the Diviner differential page /book/phorge/article/differential/
Click on the link to Differential User Guide: Inline Comments

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Tue, Sep 5, 16:05

Owners added a reviewer: O1: Blessed Committers.Tue, Sep 5, 16:05

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Sep 5, 16:05

Sten requested review of this revision.Tue, Sep 5, 16:05

Harbormaster completed remote builds in B831: Diff 1370.Tue, Sep 5, 16:05

Thaaanks

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

This revision is now accepted and ready to land.Wed, Sep 6, 10:45

Closed by commit rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link (authored by Sten). · Explain WhyWed, Sep 6, 11:23

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diviner/

controller/

DivinerFindController.php

2 lines

O1: Blessed Committers

Diff 1376

src/applications/diviner/controller/DivinerFindController.php

Loading...