Page MenuHomePhorge

Fix Diviner strlen(null) error when clicking on a link
ClosedPublic

Authored by Sten on Sep 5 2023, 16:05.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 12, 04:43
Unknown Object (File)
Tue, Jul 9, 09:42
Unknown Object (File)
Tue, Jul 9, 07:01
Unknown Object (File)
Tue, Jul 9, 07:01
Unknown Object (File)
Sun, Jul 7, 05:37
Unknown Object (File)
Tue, Jun 25, 14:48
Unknown Object (File)
Wed, Jun 19, 20:14
Unknown Object (File)
Wed, Jun 19, 20:14

Details

Summary

Fix issue whereby clicking on a link in Diviner (eg https://my.phorge.site/diviner/find/?name=Differential_User_Guide&type=article&jump=1) results in a strlen(null) error under PHP 8.1

Fixes T15635

Test Plan
  • Go into the Diviner differential page /book/phorge/article/differential/
  • Click on the link to Differential User Guide: Inline Comments

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten requested review of this revision.Sep 5 2023, 16:05

Thaaanks

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

This revision is now accepted and ready to land.Sep 6 2023, 10:45