Page MenuHomePhorge

ton (Ihor Antonov)
Jack of all Trades

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2023, 05:12 (52 w, 3 d)
Availability
Available

Recent Activity

Jul 22 2023

ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

@avivey Yes I think this is what we need.
There is a caveat though:

Jul 22 2023, 20:50 · Affects-FreeBSD, Differential

Jul 7 2023

ton added a comment to T15524: Discussion: Technical direction of Phorge.

It does seem like it is not designed for development use either..

Why do you say so?

Phorge works perfectly AFAIK with the development webserver. That is just a single command, without having to install Apache.

Jul 7 2023, 16:24

Jul 5 2023

ton closed T15524: Discussion: Technical direction of Phorge as Spite.
Jul 5 2023, 05:29
ton added a comment to T15524: Discussion: Technical direction of Phorge.

@speck I think I can see now where we have fundamental differences in our views.

Jul 5 2023, 05:29
ton added a comment to T15524: Discussion: Technical direction of Phorge.

Thanks for your replies!

Jul 5 2023, 00:26

Jul 4 2023

ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I posted this in a separate thread, but it is definitely related: https://we.phorge.it/T15524

Jul 4 2023, 17:38 · Discussion Needed, Arcanist
ton created T15524: Discussion: Technical direction of Phorge.
Jul 4 2023, 17:37

Jun 24 2023

ton committed R4:b82028194a47: subcommand: add fetch|upload subcommand.
subcommand: add fetch|upload subcommand
Jun 24 2023, 15:38
ton committed R4:5f020f639a7c: fix: correct bugphest name in Cargo.lock.
fix: correct bugphest name in Cargo.lock
Jun 24 2023, 15:38
ton committed R4:8d98a7351c2e: fix: correct bugphest name in top-level Cargo.toml.
fix: correct bugphest name in top-level Cargo.toml
Jun 24 2023, 14:44
ton committed R4:37cf7232f7ae: readme: list workspaces in the repo.
readme: list workspaces in the repo
Jun 24 2023, 14:42
ton committed R4:593ce3f17e5e: first commit on phorge.
first commit on phorge
Jun 24 2023, 14:36

Jun 22 2023

ton updated the task description for T15364: arc land complaints summary by FreeBSD community.
Jun 22 2023, 15:03 · Arcanist, Differential, Affects-FreeBSD

May 15 2023

ton added a comment to T15364: arc land complaints summary by FreeBSD community.

Chaining Diffs is something that we would like to use more often, and it is definitely not used enough today. FreeBSD is a large codebase and making any change that is bigger than trivial often involves touching multiple parts of the system, the most difficult kind of change is architectural changes. We are limited by our tooling to a certain degree:

  • Keeping everything in one Diff makes it very difficult to review as well as reach consensus, as there are often multiple responsible parties involved. It also violates the ethos of Phab/Phorge of having small atomic changes.
  • Breaking changes down in smaller chunks has lots of downsides too - it is very hard to track and changes often get lost in depths of Differential.
May 15 2023, 19:55 · Arcanist, Differential, Affects-FreeBSD

May 9 2023

ton updated subscribers of T15364: arc land complaints summary by FreeBSD community.
May 9 2023, 18:48 · Arcanist, Differential, Affects-FreeBSD
ton updated subscribers of T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
May 9 2023, 18:48 · Affects-FreeBSD, Differential
ton updated subscribers of T15250: Raw use of "git diff" provides insufficient Diff Context.
May 9 2023, 18:47 · Affects-FreeBSD, Differential
ton updated subscribers of T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
May 9 2023, 18:47 · Discussion Needed, Arcanist

May 8 2023

ton reopened T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Open.
May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton reopened T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as "Open".

@valerio.bozzolan right, I forgot the important bit, sorry :D

May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as Resolved.
May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

In an ideal world the solution should be as simple as having a template somewhere in {{repo_root}}/.arcanist/commit_template.j2 that arcanist injects values in and renders.

May 8 2023, 01:55 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98].

arc patch problem is likely fixed. But I encountered similar problem here
https://we.phorge.it/T15351#8287

May 8 2023, 00:49 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton added a comment to T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98].

This seems to have fixed the problem. But let me try a bit more Diffs to be extra sure

May 8 2023, 00:38 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton added a comment to T15351: Create repository for Conduit API client in Rust.

I see what you are saying. I quite like Lua and how neovim uses it to achieve this extensibility...

May 8 2023, 00:28 · Phactory: Community Projects

May 7 2023

ton added a comment to T15351: Create repository for Conduit API client in Rust.

@speck the whole point of an alternative phab client implementation is remove friction that comes with arcanist. Namely:

May 7 2023, 21:36 · Phactory: Community Projects
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already

May 7 2023, 18:56 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

re @avivey : arc land --hold sort of works but look at the ergonomics:

May 7 2023, 16:42 · Arcanist, Differential, Affects-FreeBSD
valerio.bozzolan awarded T15364: arc land complaints summary by FreeBSD community a Like token.
May 7 2023, 09:30 · Arcanist, Differential, Affects-FreeBSD
ton updated the task description for T15364: arc land complaints summary by FreeBSD community.
May 7 2023, 06:35 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
May 7 2023, 03:03 · Affects-FreeBSD, Differential

May 6 2023

ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

more details about arc land - https://we.phorge.it/T15364

May 6 2023, 23:11 · Discussion Needed, Arcanist
ton created T15364: arc land complaints summary by FreeBSD community.
May 6 2023, 23:08 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15351: Create repository for Conduit API client in Rust.

Thanks @avivey !

May 6 2023, 16:56 · Phactory: Community Projects

May 5 2023

valerio.bozzolan awarded T15351: Create repository for Conduit API client in Rust a Yellow Medal token.
May 5 2023, 19:09 · Phactory: Community Projects
ton created T15351: Create repository for Conduit API client in Rust.
May 5 2023, 16:25 · Phactory: Community Projects

Apr 28 2023

ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

@avivey many developers do not use arcanist at all for reasons outlined in https://we.phorge.it/T15096#6224 - many do not wish to install php, some find arc interface confusing...

Apr 28 2023, 16:13 · Affects-FreeBSD, Differential

Apr 17 2023

ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

It is hard to say objectively, as I am new to PHP and to this codebase in particular. In total I spent probably 4-6 hours over the weekend, but someone with more experience could've done a lot more in that time. I was reading about PHP, setting up my dev environment, reading the code, navigating class hierarchy, trying to understand PHP idioms, etc. In the end of the day I realized that learning yet another language (and TBH not the most sexy one) in my free time to hack on a gigantic legacy codebase is not something that I want to do.

Apr 17 2023, 21:16 · Affects-FreeBSD, Differential
ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Ok, after spending a weekend looking at PHP I can say that I overestimated my level of enthusiasm. This is the kind of work that I'd like to get paid for and not spend my free time on.
Sorry @avivey, but you can cross me off the list of potential code contributors.

Apr 17 2023, 19:39 · Affects-FreeBSD, Differential

Apr 14 2023

ton updated subscribers of T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Apr 14 2023, 14:47 · Discussion Needed, Arcanist
ton added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

@valerio.bozzolan yes, https://gitpull.it/D110 demonstrates the point I was trying to communicate. No buttons available to expand the context.

Apr 14 2023, 14:11 · Affects-FreeBSD, Differential
valerio.bozzolan awarded T15250: Raw use of "git diff" provides insufficient Diff Context a Yellow Medal token.
Apr 14 2023, 12:57 · Affects-FreeBSD, Differential
ton created T15250: Raw use of "git diff" provides insufficient Diff Context.
Apr 14 2023, 03:15 · Affects-FreeBSD, Differential
ton updated ton.
Apr 14 2023, 01:55
ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Having been invited to chime in from Q46 I will leave my 2 cents here:

Apr 14 2023, 00:48 · Discussion Needed, Arcanist

Apr 13 2023

ton renamed T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends from Genrate `From:`, `Subject:` and `Date` fields in download raw .diff URL to Generate [From, Subject, Date] fields in download raw .diff URL.
Apr 13 2023, 23:32 · Affects-FreeBSD, Differential
ton updated subscribers of T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Apr 13 2023, 23:31 · Affects-FreeBSD, Differential
ton added a comment to Q46: Attribution of Differential revisions..

Done https://we.phorge.it/T15249

Apr 13 2023, 23:30
ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

I don't mind if someone points me at the right place in code so I can try my luck with writing PHP.

Apr 13 2023, 23:29 · Affects-FreeBSD, Differential
ton created T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Apr 13 2023, 23:23 · Affects-FreeBSD, Differential
ton closed Q47: Genrate `From:`, `Subject:` and `Date` fields in download raw .diff URL as invalid.
Apr 13 2023, 23:21 · Differential
ton asked Q47: Genrate `From:`, `Subject:` and `Date` fields in download raw .diff URL.
Apr 13 2023, 23:20 · Differential
ton added a comment to Q46: Attribution of Differential revisions..

Thanks, will do!
Test Edit comment

Apr 13 2023, 23:12
ton added a comment to Q46: Attribution of Differential revisions. (Answer 57).
Apr 13 2023, 16:19
ton added Q46: Attribution of Differential revisions. (Answer 56).
Apr 13 2023, 04:04
ton updated the question details for Q46: Attribution of Differential revisions..
Apr 13 2023, 02:42
ton asked Q46: Attribution of Differential revisions..
Apr 13 2023, 02:41

Apr 12 2023

ton asked Q45: PostgreSQL support.
Apr 12 2023, 05:25