Page MenuHomePhorge

Fix PHP 8.1 auth view strlen(null) error
ClosedPublic

Authored by Sten on Sep 5 2023, 14:16.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 11, 03:52
Unknown Object (File)
Tue, Jul 9, 09:25
Unknown Object (File)
Tue, Jul 9, 05:22
Unknown Object (File)
Tue, Jul 9, 04:38
Unknown Object (File)
Tue, Jul 9, 04:34
Unknown Object (File)
Fri, Jul 5, 20:13
Unknown Object (File)
Sun, Jun 30, 18:24
Unknown Object (File)
Sun, Jun 30, 18:24

Details

Summary

Trying to view a Jira auth provider from https://my.phorge.site/auth/ results in strlen(): Passing null to parameter #1 ($string) of type string is deprecated

This change fixes it

Fixes T15634

Test Plan

Go to https://my.phorge.site/auth/ and have a Jira already setup.
Click on Jira auth provider
Confirm the page is displayed and no error is generated.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten requested review of this revision.Sep 5 2023, 14:16

I tried to test this but I have not a real JIRA account and I was not able to test a non-null value. But, I inspected all the definitions of that method and it seems it only returns pht() so I would assume that it only returns strings.

This revision is now accepted and ready to land.Sep 10 2023, 00:27