Page MenuHomePhorge
Feed All Stories

Sep 4 2023

aklapper created T15632: PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project.
Sep 4 2023, 12:21 · PHP 8 support
valerio.bozzolan closed D25413: Show a link to the Phorge homepage.
Sep 4 2023, 11:31
valerio.bozzolan committed rHP8e19e94e3b6f: Show a link to the Phorge homepage.
Show a link to the Phorge homepage
Sep 4 2023, 11:31
valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Content is not in something, rather it's licensed under.

Sep 4 2023, 11:27 · Discussion Needed, Governance
bekay closed T15583: Typeahead datasource query for repos should match substrings as Resolved.

This is now resolved.

Sep 4 2023, 11:14 · Feature Requests, Diffusion
aklapper closed D25415: Make InterpreterBlockRule regex only match on valid interpreter names.
Sep 4 2023, 11:12
aklapper committed rP7868ab3754fa: Make InterpreterBlockRule regex only match on valid interpreter names.
Make InterpreterBlockRule regex only match on valid interpreter names
Sep 4 2023, 11:12
valerio.bozzolan updated the task description for T15322: Footer: specify a default Libre license for Phorge contents.
Sep 4 2023, 11:07 · Discussion Needed, Governance
valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Thanks @aklapper, feel free to edit the Task description according to your proposal.

Sep 4 2023, 11:04 · Discussion Needed, Governance
valerio.bozzolan accepted D25415: Make InterpreterBlockRule regex only match on valid interpreter names.

Nice catch. I agree that we should allow to have texts like asd {{{ lol }}} whey without any nuclear implosion needed by design just because we are trying to give support to cowsay or figlet.

Sep 4 2023, 10:51
bekay closed D25430: Implement ferret engine in typeahead datasource query for repos.
Sep 4 2023, 07:48
bekay committed rPdc10a7e69ea3: Implement ferret engine in typeahead datasource query for repos.
Implement ferret engine in typeahead datasource query for repos
Sep 4 2023, 07:48
avivey accepted D25413: Show a link to the Phorge homepage.
Sep 4 2023, 06:26

Sep 3 2023

avivey committed R6:4322021080d4: Allow Instance queries to appear in Dashboards.
Allow Instance queries to appear in Dashboards
Sep 3 2023, 20:56
avivey committed R6:c9b9dc3eb624: Crumbs in Item page should lead to item list, not type page.
Crumbs in Item page should lead to item list, not type page
Sep 3 2023, 20:56
avivey changed the image for Image Macro "allthethings".
Sep 3 2023, 06:43
avivey accepted D25430: Implement ferret engine in typeahead datasource query for repos.

makeitso

Sep 3 2023, 06:41

Sep 2 2023

aklapper added a comment to T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field.

<tl;dr>: This is a mismatch between legacy field keys still used for paging, versus modern field keys.

Sep 2 2023, 17:09 · Affects-Wikimedia, Bug Reports
bekay updated the diff for D25430: Implement ferret engine in typeahead datasource query for repos.

Add back code which shouldn't be removed.

Sep 2 2023, 17:01
bekay updated the diff for D25430: Implement ferret engine in typeahead datasource query for repos.

Fix linting warnings.

Sep 2 2023, 16:58
bekay requested review of D25430: Implement ferret engine in typeahead datasource query for repos.
Sep 2 2023, 16:24
bekay added a revision to T15583: Typeahead datasource query for repos should match substrings: D25430: Implement ferret engine in typeahead datasource query for repos.
Sep 2 2023, 16:24 · Feature Requests, Diffusion
aklapper created T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field.
Sep 2 2023, 14:11 · Affects-Wikimedia, Bug Reports
aklapper updated the diff for D25415: Make InterpreterBlockRule regex only match on valid interpreter names.

Shorten too long line

Sep 2 2023, 11:33
aklapper updated the diff for D25415: Make InterpreterBlockRule regex only match on valid interpreter names.

Simplify code with neat functions as proposed by Valerio

Sep 2 2023, 11:31
aklapper added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) and Apache 2.0 unless otherwise noted.

Sep 2 2023, 10:45 · Discussion Needed, Governance
aklapper added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

This would also help Wikimedia volunteers to upload screenshots of Phorge to Wikimedia Commons, avoiding annoying deletion procedures for the lack of the license in the very same page etc.

Sep 2 2023, 10:31 · Discussion Needed, Governance
aklapper closed T15601: PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 2 2023, 09:16 · PHP 8 support
aklapper closed D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.
Sep 2 2023, 09:16
aklapper closed T15601: PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists as Resolved by committing rPcef12d8dc202: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type….
Sep 2 2023, 09:16 · PHP 8 support
aklapper committed rPcef12d8dc202: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type….
Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type…
Sep 2 2023, 09:16
aklapper closed T15603: Exception: Call to undefined method PhutilJSON::encodeAsObject() as Resolved by committing rP68c687affdca: Fix call to undefined method PhutilJSON::encodeAsObject().
Sep 2 2023, 09:13
aklapper closed D25391: Fix call to undefined method PhutilJSON::encodeAsObject().
Sep 2 2023, 09:13
aklapper committed rP68c687affdca: Fix call to undefined method PhutilJSON::encodeAsObject().
Fix call to undefined method PhutilJSON::encodeAsObject()
Sep 2 2023, 09:13

Sep 1 2023

bekay awarded Blog Post: August 2023 Release a Party Time token.
Sep 1 2023, 13:54
valerio.bozzolan awarded Blog Post: August 2023 Release a Love token.
Sep 1 2023, 09:16
avivey created Blog Post: August 2023 Release.
Sep 1 2023, 09:12
avivey added a comment to T15174: Phorge←GitHub: create a bot that imports "Pull requests".

Nuance has a "GitHub Repository: Import issues and pull requests from a GitHub repository" Source Type - it might already be doing something related?

Sep 1 2023, 09:02 · Phactory: Community Projects, User-valerio.bozzolan, GitHub
avivey renamed T15554: Handling PHP deprecations: convert to Setup Issues from Handling PHP deprecations: Maybe convert to Setup Issues? to Handling PHP deprecations: convert to Setup Issues.
Sep 1 2023, 08:54 · Phorge
avivey edited the content of 2023 Week 32.
Sep 1 2023, 08:12
avivey edited the content of 2023 Week 23.
Sep 1 2023, 08:11

Aug 31 2023

valerio.bozzolan updated the summary of D25413: Show a link to the Phorge homepage.
Aug 31 2023, 20:47
waldyrious accepted D25413: Show a link to the Phorge homepage.

LGTM! :D

Aug 31 2023, 20:32
tinloaf awarded rP69c64c1e83e2: Teach Commit View about Encoding a Love token.
Aug 31 2023, 19:46
avivey closed D25360: Teach Commit View about Encoding.
Aug 31 2023, 18:00
avivey committed rP69c64c1e83e2: Teach Commit View about Encoding.
Teach Commit View about Encoding
Aug 31 2023, 18:00
avivey closed D25386: log deprecation events in Dark Console.
Aug 31 2023, 15:18
avivey committed rP94c0774d8055: log deprecation events in Dark Console.
log deprecation events in Dark Console
Aug 31 2023, 15:18
avivey closed D25387: Error handling: send Deprecation messages as explicit Event.
Aug 31 2023, 15:14
avivey committed rARCd343be59269a: Error handling: send Deprecation messages as explicit Event.
Error handling: send Deprecation messages as explicit Event
Aug 31 2023, 15:14
avivey added a comment to D25359: Generate more fields in Download Raw Diff.

hey, @ton - is this useful for you?

Aug 31 2023, 15:10 · Differential
avivey added a comment to Q74: Minio over HTTP (without SSL) as an S3 backend (Answer 100).

yeah, just default to https if it doesn't include a schema, and I think it should be fine in that regards.
There's probably already some method somewhere that looks at a uri and chooses HTTPFuture or HTTPSFuture based on the schema...

Aug 31 2023, 11:47
avivey edited Description on Trusted Contributors.
Aug 31 2023, 11:45
alufers2 added a comment to Q74: Minio over HTTP (without SSL) as an S3 backend (Answer 100).

I'm guessing this would break existing configurations. (Or we could detect if the endpoint contains the schema and prepend https:// only if it doesn't - for backwards compatibility).

Aug 31 2023, 11:45
avivey added a member for Trusted Contributors: alufers2.
Aug 31 2023, 11:45
avivey added Q74: Minio over HTTP (without SSL) as an S3 backend (Answer 100).
Aug 31 2023, 11:43
valerio.bozzolan awarded Q74: Minio over HTTP (without SSL) as an S3 backend a Like token.
Aug 31 2023, 11:33 · Phorge
alufers2 asked Q74: Minio over HTTP (without SSL) as an S3 backend.
Aug 31 2023, 11:07 · Phorge
valerio.bozzolan updated the diff for D25413: Show a link to the Phorge homepage.
  • rollback CSS change
Aug 31 2023, 08:45
valerio.bozzolan updated the summary of D25413: Show a link to the Phorge homepage.
Aug 31 2023, 08:44
valerio.bozzolan added a comment to D25413: Show a link to the Phorge homepage.

Better now?

Aug 31 2023, 08:44
valerio.bozzolan updated the diff for D25413: Show a link to the Phorge homepage.
  • integrate tips from reviewers
Aug 31 2023, 08:43
valerio.bozzolan updated the name of F344028: Phorge home proposal.png from "Screenshot_2023_08_31_104248.png" to "Phorge home proposal.png".
Aug 31 2023, 08:43
avivey triaged T15630: Fix Fonts as High priority.
Aug 31 2023, 08:22
valerio.bozzolan added a comment to T15049: Segoe UI Symbol provides bad user experience.

Just to inform that maybe a sub-task bug report will be created soon. Related discussion: https://phabricator.wikimedia.org/T333885#9132176

Aug 31 2023, 08:08 · Fonts
valerio.bozzolan triaged T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out as Normal priority.
Aug 31 2023, 07:46 · Bug Reports, Differential
avivey added Q73: File Visibility (Answer 99).
Aug 31 2023, 07:07
avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 31 2023, 06:44
valerio.bozzolan added a comment to D25420: Improving UX for ignoring timezone conflicts.

(I accepted but before landing please first review all not-done inline comments: https://we.phorge.it/differential/revision/inlines/25420/ and this comment: https://we.phorge.it/D25420#12264 )

Aug 31 2023, 05:13
valerio.bozzolan accepted D25420: Improving UX for ignoring timezone conflicts.

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

  • Instead of "You can ignore this conflict or adjust your profile setting to match your client", we should use the same order in the sentence as the options are shown to the user: "You can adjust your profile setting to match your client, or ignore this conflict."
  • The label for the checkbox should be just "Ignore Conflict", without the "Or" at the start.
  • When the "Ignore Conflict" checkbox is selected, the timezone dropdown should be disabled (and re-enabled if the checkbox is unmarked)
Aug 31 2023, 05:09

Aug 30 2023

waldyrious added a comment to D25413: Show a link to the Phorge homepage.

Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".

Aug 30 2023, 18:46
waldyrious added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

maybe in the future we can have a CSS selector to be applied just to the "phorge/" pathname, in order to avoid mouse selection, and select just the command.

Aug 30 2023, 18:38
waldyrious abandoned D25426: Fix label of submit button in timezone conflict dialog.

See D25420 for a conflicting change...

Aug 30 2023, 18:32
waldyrious added a comment to D25420: Improving UX for ignoring timezone conflicts.

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

Aug 30 2023, 18:27
avivey closed D25429: Generate Diviner book for Javelin.
Aug 30 2023, 18:20
avivey committed rPaeab4efe17cf: Generate Diviner book for Javelin.
Generate Diviner book for Javelin
Aug 30 2023, 18:20
chris accepted D25429: Generate Diviner book for Javelin.
Aug 30 2023, 18:17
avivey requested review of D25429: Generate Diviner book for Javelin.
Aug 30 2023, 18:17
kfoster asked Q73: File Visibility.
Aug 30 2023, 17:56
valerio.bozzolan marked Q72: Add support for Cloudflare Turnstile (A Captcha alternative)? (Answer 97) as hidden.
Aug 30 2023, 16:25
avivey added a comment to D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.

Check out https://we.phorge.it/book/contrib/article/javascript_coding_standards/ and the Javeline docs here: https://github.com/phacility/javelin/tree/master/src/docs/concepts
(I'll try to render the Javeline guide here later).

Aug 30 2023, 14:24
valerio.bozzolan added a comment to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.

Sorry, I mean this link:

Aug 30 2023, 14:21 · Bug Reports
valerio.bozzolan added a comment to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.

I absolutely don't know what we are doing here since I don't know the supposed "Phabricator way" to interact with the DOM via JavaScript using its library.

Aug 30 2023, 14:20 · Bug Reports
roberto.urbani updated the test plan for D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:45
roberto.urbani requested review of D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:44
roberto.urbani added a revision to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized: D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:44 · Bug Reports
valerio.bozzolan attached a referenced file: F274834: Comments deleted Before D25096.png.
Aug 30 2023, 10:20
valerio.bozzolan attached a referenced file: F274835: Comments deleted After D25096.png.
Aug 30 2023, 10:20
valerio.bozzolan edited the content of 2023 Week 32.
Aug 30 2023, 07:50
valerio.bozzolan added a comment to F343635: Phorge written on Wikipedian shirt.png.

Screenshot from:

Aug 30 2023, 07:43
valerio.bozzolan added a comment to Wikimania Hackathon 2023 Singapore.

We were able to push Phorge subliminal messages in an official Wikimedia video \o/

Aug 30 2023, 07:42
valerio.bozzolan updated the name of F343635: Phorge written on Wikipedian shirt.png from "Phorge written on Wikipedia shirt.png" to "Phorge written on Wikipedian shirt.png".
Aug 30 2023, 07:41
valerio.bozzolan updated the name of F343635: Phorge written on Wikipedian shirt.png from "Screenshot_2023_08_30_093752.png" to "Phorge written on Wikipedia shirt.png".
Aug 30 2023, 07:41
valerio.bozzolan added a comment to D25413: Show a link to the Phorge homepage.

Yeah thanks! Maybe we can somehow keep the footer, in order to have a link for people like me that just have their brain switched-off and just look at the bottom link. Also maybe we can simplify a little bit.

Aug 30 2023, 07:31
valerio.bozzolan added a revision to T15006: Re-brand Phorge: D25425: Remove mention of Phabricator in the Auth setup check.
Aug 30 2023, 07:07 · Phorge
valerio.bozzolan updated the summary of D25425: Remove mention of Phabricator in the Auth setup check.
Aug 30 2023, 07:07
valerio.bozzolan updated the summary of D25425: Remove mention of Phabricator in the Auth setup check.
Aug 30 2023, 07:07
valerio.bozzolan added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

Thanks for this patch. Yeah if I understand correctly, this should work:

Aug 30 2023, 07:06
valerio.bozzolan added a comment to D25427: Clarifying the operating system choices..

I'm Valerio, a simple person: I see "GNU/Linux" and I say "yeah, land".

Aug 30 2023, 06:45 · Documentation
valerio.bozzolan added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 30 2023, 06:40