Page MenuHomePhorge
Feed All Stories

Sep 16 2023

aklapper added a revision to T15637: Undefined index exception setting Meme text: D25437: Fix "Undefined index" exception setting Meme text.
Sep 16 2023, 12:14 · PHP 8 support
aklapper created T15637: Undefined index exception setting Meme text.
Sep 16 2023, 12:13 · PHP 8 support

Sep 15 2023

20after4 updated subscribers of D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).
Sep 15 2023, 10:43
20after4 added a comment to D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

Sep 15 2023, 10:42
20after4 accepted D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

I like it but I haven't tested locally.

Sep 15 2023, 10:39
avivey added a comment to Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 104).

Yeah, I generally agree with "let the user set the width of the page"...

Sep 15 2023, 08:28
ken added a comment to Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 104).

Thanks Eyal for the quick answer.

Sep 15 2023, 08:22
avivey added Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 104).
Sep 15 2023, 08:08
ken added Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 103).
Sep 15 2023, 02:46

Sep 14 2023

valerio.bozzolan updated the answer details for Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 102).
Sep 14 2023, 19:52
valerio.bozzolan updated the answer details for Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 102).
Sep 14 2023, 19:52
valerio.bozzolan updated the answer details for Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 102).
Sep 14 2023, 19:51
valerio.bozzolan added Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 102).
Sep 14 2023, 19:50

Sep 13 2023

revi awarded T15554: Handling PHP deprecations: convert to Setup Issues a The World Burns token.
Sep 13 2023, 16:40 · Phorge
valerio.bozzolan retitled D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages) from Workboard: Milestone Name changable in 4 clicks instead of 6
Sep 13 2023, 08:40

Sep 12 2023

Sten updated the diff for D25436: Update PhutilCowsay.php to work for small cows.

Update unit test

Sep 12 2023, 16:12
Sten planned changes to D25436: Update PhutilCowsay.php to work for small cows.
Sep 12 2023, 16:10
Sten requested review of D25436: Update PhutilCowsay.php to work for small cows.
Sep 12 2023, 16:09
Sten closed D25435: Fix rendering of cowsay sheep.cow.
Sep 12 2023, 14:57
Sten committed rARC35e127da57a8: Fix rendering of cowsay sheep.cow.
Fix rendering of cowsay sheep.cow
Sep 12 2023, 14:57

Sep 11 2023

avivey accepted D25435: Fix rendering of cowsay sheep.cow.
Sep 11 2023, 19:04
Sten updated the diff for D25435: Fix rendering of cowsay sheep.cow.

Updates as per reviews

Sep 11 2023, 12:39
Sten closed T15634: auth view results in strlen(null) error under PHP 8.1, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 11 2023, 10:57 · PHP 8 support
Sten closed T15634: auth view results in strlen(null) error under PHP 8.1 as Resolved by committing rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error.
Sep 11 2023, 10:57 · PHP 8 support
Sten closed D25432: Fix PHP 8.1 auth view strlen(null) error.
Sep 11 2023, 10:57
Sten committed rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error.
Fix PHP 8.1 auth view strlen(null) error
Sep 11 2023, 10:57
Sten updated the diff for D25434: Add documentation for cowsay.

Add a note about figlet

Sep 11 2023, 10:56
valerio.bozzolan added inline comments to D25435: Fix rendering of cowsay sheep.cow.
Sep 11 2023, 10:48
avivey added a comment to D25435: Fix rendering of cowsay sheep.cow.

Can you add a couple of tests to https://we.phorge.it/source/arcanist/browse/master/src/utils/__tests__/cowsay/ ?

Sep 11 2023, 10:32
Sten updated the summary of D25435: Fix rendering of cowsay sheep.cow.
Sep 11 2023, 10:13
Sten requested review of D25435: Fix rendering of cowsay sheep.cow.
Sep 11 2023, 10:12
valerio.bozzolan added a comment to Q76: How can I display a checklist to users depending on the current status and type of the ticket? (Answer 101).

I'm talking about Herald Webhook, not Herald Rule. So you can write some web code that is visited when something happens, so you can run custom code when that happens, and you can edit your Tasks.

Sep 11 2023, 09:48
vidhya added a comment to Q76: How can I display a checklist to users depending on the current status and type of the ticket? (Answer 101).

Thanks for the Answer @valerio.bozzolan.
I have created those checklists as custom fields. The problem I have is all these lists are shown in all types of tickets and statuses.
But later with this checklist, I want to control the the status transition.
Eg: Only when "Checklist 1" and "Checklist 2" are selected, User should be able to change the status from In progress - Ready for testing.

Sep 11 2023, 09:33
valerio.bozzolan updated the answer details for Q76: How can I display a checklist to users depending on the current status and type of the ticket? (Answer 101).
Sep 11 2023, 07:31
valerio.bozzolan added Q76: How can I display a checklist to users depending on the current status and type of the ticket? (Answer 101).
Sep 11 2023, 07:30
vidhya asked Q76: How can I display a checklist to users depending on the current status and type of the ticket?.
Sep 11 2023, 06:37
ken asked Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do.
Sep 11 2023, 06:30

Sep 10 2023

Ekubischta added a comment to T15450: Configure another Ponder Question status "Closed, Graduated".

Seems like it is solvable via

Sep 10 2023, 14:08 · Ponder, phorge.it install
valerio.bozzolan accepted D25432: Fix PHP 8.1 auth view strlen(null) error.

I tried to test this but I have not a real JIRA account and I was not able to test a non-null value. But, I inspected all the definitions of that method and it seems it only returns pht() so I would assume that it only returns strings.

Sep 10 2023, 00:27
valerio.bozzolan updated the test plan for D25432: Fix PHP 8.1 auth view strlen(null) error.
Sep 10 2023, 00:19

Sep 9 2023

aklapper closed T15632: PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 9 2023, 18:55 · PHP 8 support
aklapper closed D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Sep 9 2023, 18:55
aklapper closed T15632: PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project as Resolved by committing rPa65061ddc33d: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Sep 9 2023, 18:55 · PHP 8 support
aklapper committed rPa65061ddc33d: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field
Sep 9 2023, 18:55
valerio.bozzolan added a comment to T15632: PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project.

I think this is apparently unrelated to projects. It's just needed to edit something else, keeping the date field as empty.

Sep 9 2023, 18:33 · PHP 8 support
valerio.bozzolan retitled D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field from Fix PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project
Sep 9 2023, 18:32
valerio.bozzolan updated the test plan for D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Sep 9 2023, 18:32
valerio.bozzolan accepted D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.

Tested. Thanks!

Sep 9 2023, 18:31
valerio.bozzolan added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

What do you think about the related tip? Also here I can maybe try to propose a counter-patch next week

Sep 9 2023, 14:55 · UX
valerio.bozzolan added a comment to D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.

What do you think about? Maybe I can try to propose a counter-patch about the related tip

Sep 9 2023, 14:54

Sep 8 2023

Sten added inline comments to D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.
Sep 8 2023, 08:35
Sten accepted D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Sep 8 2023, 08:17
avivey committed R6:ef927d616f71: Add quick-access buttons to lists.
Add quick-access buttons to lists
Sep 8 2023, 08:09

Sep 7 2023

aklapper updated the task description for T15636: Project page (using its slug in URL) is a 404 after renaming project.
Sep 7 2023, 13:35 · Bug Reports
aklapper created T15636: Project page (using its slug in URL) is a 404 after renaming project.
Sep 7 2023, 13:32 · Bug Reports
Sten added a comment to D25434: Add documentation for cowsay.

Please wait 2-3 days before landing, so other people can share useful tips

Sep 7 2023, 13:27
valerio.bozzolan accepted D25434: Add documentation for cowsay.

Yeah why not, thanks

Sep 7 2023, 08:19

Sep 6 2023

valerio.bozzolan edited the content of Planning Meetings.
Sep 6 2023, 11:33 · phorge.it install
valerio.bozzolan updated the diff for D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

comments more sexier for reviewers

Sep 6 2023, 11:24
Sten closed T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 6 2023, 11:24 · PHP 8 support
Sten closed T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1 as Resolved by committing rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link.
Sep 6 2023, 11:23 · PHP 8 support
Sten closed D25433: Fix Diviner strlen(null) error when clicking on a link.
Sep 6 2023, 11:23
Sten committed rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link.
Fix Diviner strlen(null) error when clicking on a link
Sep 6 2023, 11:23
Sten updated the diff for D25434: Add documentation for cowsay.

Updated differential_faq.diviner as per review.

Sep 6 2023, 11:19
valerio.bozzolan added inline comments to D25421: Audit Feed: less verbose when the author is the committer.
Sep 6 2023, 11:09
valerio.bozzolan accepted D25433: Fix Diviner strlen(null) error when clicking on a link.

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

Sep 6 2023, 10:45
valerio.bozzolan added a comment to D25434: Add documentation for cowsay.

Nice! Just few inline tips

Sep 6 2023, 08:26
valerio.bozzolan added a comment to T15401: Make the Remarkup Help Page Extensible.

While it could be nice to have this, in the meanwhile I think that having something minimal like D25434 would be nice

Sep 6 2023, 08:25 · Documentation, Remarkup
valerio.bozzolan edited the content of Next Up.
Sep 6 2023, 08:19
Sten updated the diff for D25434: Add documentation for cowsay.

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

Sep 6 2023, 06:57
Sten updated the diff for D25434: Add documentation for cowsay.

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

Sep 6 2023, 06:56

Sep 5 2023

Sten planned changes to D25434: Add documentation for cowsay.

lol

Just a question. Why under differential and not related to Remarkup?

Sep 5 2023, 19:42
valerio.bozzolan added a comment to D25434: Add documentation for cowsay.

Just a question. Why under differential and not related to Remarkup?

Sep 5 2023, 16:35
Sten closed D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Sep 5 2023, 16:33
Sten closed T15574: PHP8.1: strlen() null exception when creating a tab panel in a dashboard, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 5 2023, 16:33 · PHP 8 support
Sten closed T15574: PHP8.1: strlen() null exception when creating a tab panel in a dashboard as Resolved by committing rP1720209f16c3: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Sep 5 2023, 16:33 · PHP 8 support
Sten committed rP1720209f16c3: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Various PHP 8.1 strlen(null) fixes for Dashboard Panels
Sep 5 2023, 16:33
Sten added a comment to D25434: Add documentation for cowsay.
___________________________ < Please approve this diff! > --------------------------- \ . . \ / `. .' " \ .---. < > < > .---. \ | \ \ - ~ ~ - / / | _____ ..-~ ~-..-~ | | \~~~\.' `./~~~/ --------- \__/ \__/ .' O \ / / \ " (_____, `._.' | } \/~~~/ `----. / } | / \__/ `-. | / | / `. ,~~| ~-.__| /_ - ~ ^| /- _ `..-' | / | / ~-. `-. _ _ _ |_____| |_____| ~ - . _ _ _ _ _>
Sep 5 2023, 16:31
Sten requested review of D25434: Add documentation for cowsay.
Sep 5 2023, 16:29
Sten requested review of D25433: Fix Diviner strlen(null) error when clicking on a link.
Sep 5 2023, 16:05
Sten added a revision to T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1: D25433: Fix Diviner strlen(null) error when clicking on a link.
Sep 5 2023, 16:05 · PHP 8 support
Sten claimed T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1.
Sep 5 2023, 16:01 · PHP 8 support
Sten created T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1.
Sep 5 2023, 16:01 · PHP 8 support
valerio.bozzolan added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Nice catch

Sep 5 2023, 14:52 · UX
avivey accepted D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Sep 5 2023, 14:29
Sten added a comment to D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.

Hi all, can this be approved if no one has any objections? Dashboards simply can't be modified under PHP 8.1 without this. Thanks.

Sep 5 2023, 14:18
Sten requested review of D25432: Fix PHP 8.1 auth view strlen(null) error.
Sep 5 2023, 14:16
Sten added a revision to T15634: auth view results in strlen(null) error under PHP 8.1: D25432: Fix PHP 8.1 auth view strlen(null) error.
Sep 5 2023, 14:16 · PHP 8 support
Sten claimed T15634: auth view results in strlen(null) error under PHP 8.1.
Sep 5 2023, 14:07 · PHP 8 support
Sten created T15634: auth view results in strlen(null) error under PHP 8.1.
Sep 5 2023, 14:07 · PHP 8 support
aklapper added a comment to T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field.

In theory this could be a two-liner: Changing the last character of the $prefix, and in PhabricatorCursorPagedPolicyAwareQuery.php

- $map[$field->getFieldKey()] = $field->getValueForStorage();
+ $map[$field->getModernFieldKey()] = $field->getValueForStorage();

In practice that leads to: Unhandled Exception ("PhutilTypeExtraParametersException") - Got unexpected parameters: customfield, customfield.index.table, customfield.index.key

Sep 5 2023, 11:27 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15630: Fix Fonts.

Did some digging, and it looks like Segoe is not something we can use:

Sep 5 2023, 06:14
avivey updated the task description for T15630: Fix Fonts.
Sep 5 2023, 05:52

Sep 4 2023

Matthew added a comment to T15633: Maniphest create events are out of order.

Here is the homepage feed after I created this task. Nothing indicates that there was a task creation, just a triage:

Sep 4 2023, 23:01 · Feed, Maniphest
Matthew updated the task description for T15633: Maniphest create events are out of order.
Sep 4 2023, 23:01 · Feed, Maniphest
Matthew triaged T15633: Maniphest create events are out of order as Low priority.
Sep 4 2023, 23:00 · Feed, Maniphest
avivey edited the content of Next Up.
Sep 4 2023, 16:57
aklapper requested review of D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Sep 4 2023, 16:37
aklapper added a revision to T15632: PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project: D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Sep 4 2023, 16:37 · PHP 8 support
aklapper renamed T15632: PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project from PHP 8.1 "strlen(null)" exception rendering task after adding project to PHP 8.1 "strlen(null)" exception rendering task with custom date field after adding project.
Sep 4 2023, 12:24 · PHP 8 support