Check out https://we.phorge.it/book/contrib/article/javascript_coding_standards/ and the Javeline docs here: https://github.com/phacility/javelin/tree/master/src/docs/concepts
(I'll try to render the Javeline guide here later).

• We don't use document.querySelector - we use JX.DOM.find, you can see an example in line 43
• the else should be in the same line as the }.

In D25428#12247, @avivey wrote:

• We don't use document.querySelector - we use JX.DOM.find, you can see an example in line 43

It seems undocumented also in the mentioned guide 🤔

Anyway we can also avoid to manually manage with two classlists, and adopt this oneline instead, just like line 66.

JX.DOM.alterClass(clickable_gear_element, 'core-menu-item', !userMinimize);

Thanks Roberto. If you have not time to follow-up, no problem. We can help to re-patch.