Unsure if tagging as Bug Reports

See https://we.phorge.it/T15533#11839 - the env-selecting code in ExecFuture has this logic:

• the setlocal isn't supposed to make a difference (it only applies the command string itself - ie if a file is named 🧆.txt.
• Setting E is more likely to cause this problem then to solve it...

I think these two are related here:

• https://secure.phabricator.com/T13060 (call setlocal in the master php process, so everything is always en_us)
• T15281 and https://secure.phabricator.com/T12071 (Env-vars are missing because of E)

(I'm able to reproduce. Had to apt-get install language-pack-hu for that...)

The change in src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php also seems to be solved somehow.
I tried to simulate the issue with bin/mail send-test --to mturdus --subject "" and pressing CTRL-D.
I received an empty email (containing no subject and no body).

Yeah, that's what I was worried about

Hmm, arc unit says No tests to run.:

$:acko\> git checkout authFBicon 
Switched to branch 'authFBicon'
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
$:acko\> ../arcanist/bin/arc unit
No tests to run.

(Please run full arc unit before landing - I still don't trust the automatic unit tests being invoked for this kind of changes).

Most of these look good, but I think some of it is outdated - can you check which is still needed?

lint + php 8 fix

In T15547#11813, @avivey wrote:

Is there anything that generates this URL? Is there a broken link generated anywhere?

Is there anything that generates this URL? Is there a broken link generated anywhere?

Found a related old upstream: https://secure.phabricator.com/T10326

Hashtags are not "aliases" - they are single words with # added at the start, that are references to a topic (project).

Strawman proposal:

• Rename "Additional Hashtags" to "Project Name Aliases"
• Rename "Hashtags" to "Project Name Aliases"
• Rename "Tags" to "Projects"

Is the file resources/sprite/login_2x/Facebook.png in high definition? it seems a bit grainy

"Do nothing" does nothing. It's mostly for working with the "Other Herald Rule" conditions.

Okay, that's better, some of the failures were real-ish. The remaining ones look like either incompatibilities with Windows in other code that I am not touching here, or issues due to having a different version of a linter installed than expected.

Improve error messages when a binary is missing

I am not sure if these build failures are real? I guess they are from the run on my own machine, which indeed failed on a bunch of tests, but that might be just because I don't have every linter installed? If they are real, I'd appreciate some help investigating them.

While Deploy Keys do not appear to be the tool, I just configured a new Personal Access Token that's tied to the PhorgeIt organization. If there are any issues, please open a new task and assign it to me, I'll take a look.

Do you remember what the "Do nothing" Herald rule is about?

Sorry this took me a while to get back to. I was distracted at first, and then it turned out that the lints don't work at all on Windows. (I got them working; I'll file another bug and submit a patch for that.)

Fixed lint issues

Is there a Task about this? if not, feel free to open that in Diffusion at least. I'm interested in seeing this fixed.

Ouch sorry renamed again since I forgot the discussion. Still an annoying bug and found your question.

I noted down that it did when I first hit this error, but not anymore. Now I have to go to a specific diff in which a new file has been added.

Happy to change those phutil_nonempty_string() into phutil_nonempty_scalar() because

1. The only place it matters is in DiffusionExternalController.php where this is called with:

$redirect = $repository->generateURI(
   array(
     'action' => 'browse',
     'branch' => $repository->getDefaultBranch(),
     'commit' => $id,
   ));

Maybe $id might be an int or float under some non-git VCS.