Blur profile image when user account disabled
ClosedPublic
Actions

Authored by aklapper on Jul 3 2023, 09:00.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15515: Blur profile image when account disabled

Commits

rP85539ce25559: Blur profile image when user account disabled

Summary

Add blur and sepia filter to disabled user profile image.

Before this change, the image was just greyed out but still fully recognizable.

Closes T15515

Test Plan

Create an account with a custom profile picture
Disable the account
Go to user profile of the account
Go to a task with activity of that account and hover over the account to open card view

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jul 3 2023, 09:00

Owners added a reviewer: O1: Blessed Committers.Jul 3 2023, 09:00

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 3 2023, 09:00

aklapper requested review of this revision.Jul 3 2023, 09:00

Harbormaster completed remote builds in B620: Diff 1050.Jul 3 2023, 09:00

Thanks :) What do you think about just returning a null User description? I propose that since the User profile view already says "Disabled".

I'd say "This account has been disabled" is way clearer than... nothing? :P

aklapper retitled this revision from Do not display user profile description and blur profile image when account disabled to Blur profile image when user account disabled.Jul 3 2023, 12:18

aklapper edited the summary of this revision. (Show Details)

aklapper edited the test plan for this revision. (Show Details)

Remove already implemented text parts

Harbormaster completed remote builds in B621: Diff 1051.Jul 3 2023, 12:18

Originally the image was just set to grayscale using CSS, but now it's also blurred.

It seems nice to me, thanks.

A follow-up could be, doing the same on .phui-timeline-image. But that is not possible now since the server does not expose a .phui-image-disabled there in the timeline.

This revision is now accepted and ready to land.Jul 5 2023, 11:52

valerio.bozzolan edited the summary of this revision. (Show Details)Jul 5 2023, 12:47

Closed by commit rP85539ce25559: Blur profile image when user account disabled. · Explain WhyJul 12 2023, 20:06

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP85539ce25559: Blur profile image when user account disabled.