Page MenuHomePhorge

Consider allowing milestone columns to be ordered arbitrarily on workboards
Open, Needs TriagePublic

Description

This is a change that I made to wikimedia's fork which we found quite useful. It's a trivial change but upstream wasn't interested. It could be made configurable with the default set to enforce milestone ordering or the ordering enforcement can be removed entirely, as I did for Wikimedia.

Some rationale for the change:

  • Patch: rPHAB042685bdf637: Allow milestone columns to be reordered.
    • epriestley was very much against this idea but wikimedia's users loved it.
    • Milestones, unlike subprojects, are mutually exclusive, so a task can only be in one milestone in the superproject. This has the convenience that adding a task to a milestone automatically removes it from any sibling milestone within the same superproject.
    • Reordering milestones is convenient when you want to treat milestones as workflow steps rather than sequential numerical versions. Example: https://phabricator.wikimedia.org/project/board/20/
    • upstream product vision was to use milestones exclusively for sequential things like "Maniphest V2" or sprints.
    • Wikimedia chose to abuse milestones for workflow steps and being stuck with the ordering that phabricator enforces was a big inconvenience for that use-case.

Event Timeline

epriestley was very much against this idea but wikimedia's users loved it.

Do we have epristley's reasoning as to why he was against this? Might help in deciding about including this patch in Phorge.

epriestley was very much against this idea but wikimedia's users loved it.

Do we have epristley's reasoning as to why he was against this? Might help in deciding about including this patch in Phorge.

There is quite a lot of history on this one: https://secure.phabricator.com/T12144

Reordering milestones is convenient when you want to treat milestones as workflow steps rather than sequential numerical versions.

Projects and Subprojects already have the Workboard function, which lets you create custom columns for workflow steps. It is not clearly visible in Maniphest in which column a given task is, but you can see it in the Task view and moving a task from one column to another is possible in both the Task view and Workboard view. You can reorder these columns on the Workboard however you like. Heck, you can even have multiple projects assigned to a specific task and have them in independent places on the workboard. (Useful when you're treating projects and subprojects as teams of people)

I'm honestly with epristley on this one, because I don't see a reason as to why allow the reordering of milestones, unless you're absuing them like that.

That being said, which column a particular task is in should probably be more visible in Maniphest (possibly even filterable, so that one can just show all tasks in group Engineering, column Backlog)