Diffusion Identity reassignment doesn't propagate correctly
Closed, ObsoletePublic
Actions

Asked by smith on Jun 6 2023, 14:51.

Details

Scenario:

Add some commits authored with an identity A that will get assigned to user X and some authored with an identity B that will not get assigned to anyone.
Explicitly unassign identity A from user X.
Explicitly assign identity B to user X.
Go to user X's commit list from the user X's profile page or craft a query for Diffusion commits, specifying X as author.

Expectations:
Commits A are not returned, commits B are returned — reflecting current state of identity-user mappings.

Reality:
Commits A are returned, commits B are not returned — reflecting the state of affairs at the time of indexing the commits.

Screenshots (from comment):

Here, I assigned one of your identities to myself:

Now when you go to the list of your commits, there is some entry from "me", but there shouldn't.

And when you look at my commits, there are none — but there should, as this commit is now mine, as far as Diffusion is concerned.

Event Timeline

Thanks

I'm not quite sure to have understood everything. Can you attach a cute screenshot or something? :)

This is about Diffusion identity assignment feature. List of identities is here: https://we.phorge.it/diffusion/identity/
The simplest way to test it would be to make a test repository and proceed according to the instructions as above. I hope the process is laid out quite clearly.

Here, I assigned one of your identities to myself:

Now when you go to the list of your commits, there is some entry from "me", but there shouldn't.

And when you look at my commits, there are none — but there should, as this commit is now mine, as far as Diffusion is concerned.

Ah sorry for this bug, please visit the files and set Public (I cannot see them)

Thanks :)

Done.

Let's try to reduce the surface

Is that related to just /people/commits/ in your opinion, or maybe other places?

No, your edit is not correct. The same happens in search, as I indicated in the description:

or craft a query for Diffusion commits, specifying X as author

So if after following my instructions you go to /diffusion/commit/query/all/, you see all of the commits with the author field correctly displayed. If, however, you proceed to editing a query and you select user X as author, you get the "old state".

Oh sorry I love to randomly rename things :D

Probably you have found the issue.

Probably, to speedup the query engine, there is some speculation about the filtered user, in order to do not query its details.

Ouch sorry renamed again since I forgot the discussion. Still an annoying bug and found your question.

Is there a Task about this? if not, feel free to open that in Diffusion at least. I'm interested in seeing this fixed.

We can continue the discussion in Task T15556 - thanks for reporting

Answers

valerio.bozzolan
Updated 491 Days Ago
Actions

This seems to be an incomplete feature. This is the related Task:

T15556: Improve Diffusion identity reassignment propagation

In theory, it seems there is a Diffusion script do to so, but it does not do that:

./repository rebuild-identities

Also:

./repository rebuild-identities --all-identities

New Answer

Answer

This question has been marked as closed, but you can still leave a new answer.

	F307450: image.png
	Jun 7 2023, 07:23

	F307449: image.png
	Jun 7 2023, 07:23

	F307448: image.png
	Jun 7 2023, 07:23

	F307447: image.png
	Jun 7 2023, 07:23

Diffusion Identity reassignment doesn't propagate correctlyClosed, ObsoletePublicActions

Details

Event Timeline

Answers

valerio.bozzolanUpdated 491 Days AgoActions

Event Timeline

New Answer

Answer

Diffusion Identity reassignment doesn't propagate correctly
Closed, ObsoletePublic
Actions

valerio.bozzolan
Updated 491 Days Ago
Actions