Tip for my reviewer: please use the "makeitso" meme

It does seem like it is not designed for development use either..

Why do you say so?

Phorge works perfectly AFAIK with the development webserver. That is just a single command, without having to install Apache.

In D25323#9875, @valerio.bozzolan wrote:

Uhm. What about removing a file?

Uhm. What about removing a file?

Can't find a test case in which the function returns null :-(

The workaround for me was to manually strip all of these lines:

Uhm. My root problem is: sometime I need to talk to my boss with a stand-up comedy monologue like this:

Partially related? Sometime I put my pointer hover the "Authored By <foo>" or similar fields, but they have no Hovercards. Probably easy-peasy?

Hi @speck are you still a Mercurial user? Does arc browse <file> work for you? Just for my curiosity

• coalesce

Tested with a directory, a file, a sub-file, a sub-directory. It still works ✨

use ===

It is on Diffusion > My repository > Selected commit SHA diff page. E.g. https://<domain>/R1:abdcdefgh

yeah, typo. I'll fix it again...

ok, now I understand.

Thanks :) Silly question since I'm not native English: is there a repetition in "creating revision from revision from raw diff"?

I agree and that is why the general idea is: still showing your Diffs, but, showing the selected one (even if it's not yours). So it's just a +1 entry

I suspect just listing all open revisions would make using this page even worse - users will have to wade through a giant list.

Probably this could be approved more quickly by somebody else, suggesting a Test plan that is able to trigger both cases (NULL and not null)

In an early version I did not consider "do it only in create mode". Now I think the patch D25338 does what we imagine.

Here the follow-up:

Can I just propose a veeery small fix for this (it's one line, after all), and then create another one to modernize the workflow with that component? I'm not sure I will be able to do not destroy everything if I immediately try the modernization ihih

consider just replacing the selector with a modern AphrontFormTokenizerControl - that smart search features.

I verified some lines but I need more help in the others.

fix merge conflict

Just as clarification, does this happen just visiting the Differential homepage?

Thanks. Also here I honestly need more help

For completeness - Landing revisions from the UI Since they wouldn't be able to land from git? - Would have to be enabled in the UI

(I will do some mess to flag as closed/abandoned)

I've extracted T15535: Using Differential with plain Git, without requiring Arc for the git-push-for-revision.

In T15096#11546, @avivey wrote:

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan)

🎉 This feature landed master with the following implementation:

( The CLA → https://secure.phabricator.com/L28 )

If it's urgent, we can apply a strict CLA now (basically copy Phacility), and soften it later, once we've had legal counsel.

Marginally related to T15096