Page MenuHomePhorge

matmarex (Bartosz Dziewoński)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 19 2023, 18:03 (14 w, 5 d)
Availability
Available

Recent Activity

Aug 20 2023

matmarex added inline comments to D25305: Workboard: have thin scrollbars.
Aug 20 2023, 21:07

Aug 19 2023

matmarex updated the diff for D25305: Workboard: have thin scrollbars.

Lint

Aug 19 2023, 21:48
matmarex updated the diff for D25305: Workboard: have thin scrollbars.

Restored the previous selectors, added some code comments to try to explain better why I wrote them this way. I hope this clarifies things. Thanks!

Aug 19 2023, 21:45

Aug 18 2023

matmarex added inline comments to D25305: Workboard: have thin scrollbars.
Aug 18 2023, 22:27

Aug 15 2023

matmarex updated the diff for D25341: Fix ArcanistExternalLinter on Windows.

Tweaks per review

Aug 15 2023, 22:20
matmarex updated the diff for D25305: Workboard: have thin scrollbars.

Forgot the celerity thing

Aug 15 2023, 22:10
matmarex updated the diff for D25305: Workboard: have thin scrollbars.

Added .device-desktop to some selectors as requested

Aug 15 2023, 22:09
matmarex added a comment to D25305: Workboard: have thin scrollbars.

Can you share a nice A/B test on Microsoft Windows to upload?

Aug 15 2023, 22:02

Jul 22 2023

matmarex added inline comments to D25341: Fix ArcanistExternalLinter on Windows.
Jul 22 2023, 03:33

Jul 18 2023

avivey awarded T15544: `arc lint` can't run `jshint` on Windows a Manufacturing Defect? token.
Jul 18 2023, 08:28 · Arcanist

Jul 9 2023

matmarex added a comment to D25341: Fix ArcanistExternalLinter on Windows.

Okay, that's better, some of the failures were real-ish. The remaining ones look like either incompatibilities with Windows in other code that I am not touching here, or issues due to having a different version of a linter installed than expected.

Jul 9 2023, 23:22
matmarex updated the diff for D25341: Fix ArcanistExternalLinter on Windows.

Improve error messages when a binary is missing

Jul 9 2023, 23:18
matmarex added a comment to D25341: Fix ArcanistExternalLinter on Windows.

I am not sure if these build failures are real? I guess they are from the run on my own machine, which indeed failed on a bunch of tests, but that might be just because I don't have every linter installed? If they are real, I'd appreciate some help investigating them.

Jul 9 2023, 23:04
matmarex added a revision to T15544: `arc lint` can't run `jshint` on Windows: D25341: Fix ArcanistExternalLinter on Windows.
Jul 9 2023, 22:55 · Arcanist
matmarex added a task to D25341: Fix ArcanistExternalLinter on Windows: T15544: `arc lint` can't run `jshint` on Windows.
Jul 9 2023, 22:55
matmarex requested review of D25341: Fix ArcanistExternalLinter on Windows.
Jul 9 2023, 22:53
matmarex claimed T15544: `arc lint` can't run `jshint` on Windows.
Jul 9 2023, 22:53 · Arcanist
matmarex created T15544: `arc lint` can't run `jshint` on Windows.
Jul 9 2023, 22:38 · Arcanist
matmarex added a comment to D25305: Workboard: have thin scrollbars.

Sorry this took me a while to get back to. I was distracted at first, and then it turned out that the lints don't work at all on Windows. (I got them working; I'll file another bug and submit a patch for that.)

Jul 9 2023, 21:58
matmarex updated the diff for D25305: Workboard: have thin scrollbars.

Fixed lint issues

Jul 9 2023, 21:55

Jun 22 2023

matmarex added a comment to D25305: Workboard: have thin scrollbars.

I couldn't get it to work (I was missing some dependency for the lint checks), but maybe I'll put in some more effort and try again.

Jun 22 2023, 13:57
matmarex added a revision to T15488: Thin scrollbars on workboards do not work in Firefox (on Windows): D25305: Workboard: have thin scrollbars.
Jun 22 2023, 11:56 · Maniphest, UX
matmarex added a task to D25305: Workboard: have thin scrollbars: T15488: Thin scrollbars on workboards do not work in Firefox (on Windows).
Jun 22 2023, 11:56
matmarex requested review of D25305: Workboard: have thin scrollbars.
Jun 22 2023, 11:56
matmarex created T15488: Thin scrollbars on workboards do not work in Firefox (on Windows).
Jun 22 2023, 11:48 · Maniphest, UX

Jun 20 2023

matmarex added a comment to Q63: Thin scrollbars on workboards in Firefox on Windows.

Oh, if your OS doesn't always show scrollbars, then I guess this wouldn't make a difference for you. There's probably an option somewhere to change that, if you wanted to test how it works for others. But this means that my proposed change shouldn't affect you either. :)

Jun 20 2023, 07:36
matmarex added a comment to Q63: Thin scrollbars on workboards in Firefox on Windows.

Firefox 115, Chromium 114, on Windows 10. Can you share screenshots from Firefox and Chromium on your device?

Jun 20 2023, 07:05
bekay awarded Q63: Thin scrollbars on workboards in Firefox on Windows a Like token.
Jun 20 2023, 06:36
matmarex asked Q63: Thin scrollbars on workboards in Firefox on Windows.
Jun 20 2023, 05:33