In T15105#3252, @tiguchi wrote:In T15105#3239, @Matthew wrote:In T15105#3233, @tiguchi wrote:As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:
foreach ($new_phids as $phids) { foreach ($phids as $phid) { $file_phids[] = $editor->loadPholioImage($object, $phid) ->getFilePHID(); } }This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes
Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!
I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 23 2022
Oct 23 2022
Oct 22 2022
Oct 22 2022
Oct 21 2022
Oct 21 2022
Cigaryno edited projects for T15131: Add Workboards support for Differential, added: Projects (archived); removed Maniphest (archived).
Cigaryno added a project to D25058: Fix broken file PHID extraction that causes Pholio uploads to crash: Pholio.
Cigaryno renamed T15079: Upstream translatewiki.net's changes from Upstream TranslateWiki's changes to Upstream translatewiki.net's changes.
The harbormaster has passed and you have properly fixed the bug.
NOTE: This revision is not ready to land because I am not a member of Blessed Committers. It will be ready to land once accepted by members of Blessed Committers.
In T15105#3239, @Matthew wrote:In T15105#3233, @tiguchi wrote:As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:
foreach ($new_phids as $phids) { foreach ($phids as $phid) { $file_phids[] = $editor->loadPholioImage($object, $phid) ->getFilePHID(); } }This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes
Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!
tiguchi requested review of D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Oct 19 2022
Oct 19 2022
Cigaryno renamed T15118: User icon may overlap in the user menu if no real name is set from User icon may overlap in the user manu if no real name is set to User icon may overlap in the user menu if no real name is set.
Oct 18 2022
Oct 18 2022
Did we ever find out more about the hosting situation for phorge.it?
If the users want to use milestones instead of subprojects, can they not change the language settings to Pirate English or something and go from there?
In T15105#3233, @tiguchi wrote:As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:
foreach ($new_phids as $phids) { foreach ($phids as $phid) { $file_phids[] = $editor->loadPholioImage($object, $phid) ->getFilePHID(); } }This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes
Oct 16 2022
Oct 16 2022
In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from
Array ( [+] => Array ( [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm )
Oct 15 2022
Oct 15 2022
Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.
Cigaryno renamed T15064: Make Phorge compatible with PHP 8.1/8.2/8.3 from Make phorge compatible with PHP 8.1 to Make Phorge compatible with PHP 8.1.
Oct 14 2022
Oct 14 2022
Oct 13 2022
Oct 13 2022
Can we make a draft of this document and then publish it once done?
In D25052#1750, @avivey wrote:I'd expect some PHP code to actually attach the files from attachedFilePHIDs to the relevant object, but I don't see it in this diff. Is that already happening somehow?
Hi - thanks for your response; but I was looking for support/consultancy for the upgrade - is anyone able to offer this?
Oct 12 2022
Oct 12 2022
Working around this right now by setting up a Relayed Domain on my mail server and pointing it to the server that my Phorge instance is running on. Obviously only an option if you are running your mailserver, and your configuration isn't too complex to support it.
Oct 11 2022
Oct 11 2022
k__nard added a comment to T15122: Twitch auth provider is not working - old twitch API has been decomissioned.
ok, done. But I don't know how to fix the unit tests. after running celerity map command what should I do ?
I changed everything branded Phabricator in th 10k files in my fork to Phorge and applied this change to filenames.
Another example of broken dark theme
i can see a few mentions of Phabricator on the documentation, i am not sure if its because the documentation was left out, or because there are some elments in the codebase that still mention phabricator.
where is the standard installation documentation for phorge, i only see migration
There's a difference between deleting data as a Phab/Phorge admin (which is done via the bin/delete script, and prints out a massive warning about it potentially breaking stuff and generally being a bad idea), and schema migrations done as part of an upgrade, which would happily delete data without a second thought.
Oct 10 2022
Oct 10 2022
In T15126#3165, @Cigaryno wrote:In T15126#3158, @avivey wrote:can we keep the actual deletion as optional for a very long time/forever, and at the same time not create the database for new installs?
that will allow installs to backup/export their logs even if they miss the deprecation warning.No, we should basically follow the two parts per @Matthew.
Oct 9 2022
Oct 9 2022
Also, this is fairly similar to T15082. Having Epics would probably also resolve that.
avivey committed rP4aedc206c727: Update PassphraseCredential to support Mentions (authored by Ekubischta).
Update PassphraseCredential to support Mentions
avivey closed T15049: Segoe UI Symbol provides bad user experience as Resolved by committing rPf8ffa393c442: Added cross-platform default fonts.
Added cross-platform default fonts
I feel like the idea behind milestones being strictly ordered is from the viewpoint that milestones are sequential "events" that happen in development one after another in a given order.
Oct 7 2022
Oct 7 2022
Do you talk about the DNS_PROB_STARTED error?
Oct 6 2022
Oct 6 2022
In D25055#1786, @Cigaryno wrote:Could you do this:
- Replace the Phabricator logo with the Phorge logo.
- Replace the G+ like Google logo with the current Google logo that was used since 2015.
Optional: Replace the Facebook logo with the new one that has a different blue.
LGTM, we may also upstream more Wikimedia patches, per T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Could you do this:
- Replace the Phabricator logo with the Phorge logo.
- Replace the G+ like Google logo with the current Google logo that was used since 2015.
Optional: Replace the Facebook logo with the new one that has a different blue.
In T15126#3158, @avivey wrote:can we keep the actual deletion as optional for a very long time/forever, and at the same time not create the database for new installs?
that will allow installs to backup/export their logs even if they miss the deprecation warning.
I setup a cron that makes a bunch of DNS queries for different records within the phorge.it zone from all the authoritative nameservers for the zone (see T15080#1985).
Oct 4 2022
Oct 4 2022
Just resurfaced today (now).
The original discussion in T12144 is kinda convincing to me, although it's mostly convinces me that the term "milestone" doesn't match these objects.
can we keep the actual deletion as optional for a very long time/forever, and at the same time not create the database for new installs?
that will allow installs to backup/export their logs even if they miss the deprecation warning.
Oct 3 2022
Oct 3 2022
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0