Page MenuHomePhorge

dcog (Dan)
User

Projects

User Details

User Since
Jul 6 2021, 16:29 (20 w, 6 d)

Recent Activity

Wed, Nov 17

dcog added a comment to T15025: Simple Production Docker Stack.

Thanks -- I'm curious as to what makes this not particularly suitable for development, though?

Wed, Nov 17, 01:48 · Phorge General/Unknown

Oct 29 2021

dcog added a comment to T15033: Add option for GDPR Warning Suggestion.

@golyalpha As my current employer is one of the largish companies, (50,000+ international employees), but not primarily software focused we have all been given GDPR awareness training but do not have a general, all employees, GDPR statement available nor a standard text or set of texts to use.
When I was deploying a Phabricator instance I actually had to come up with the wording myself and then get it approved by the legal & compliance team - my biggest hurdle was convincing them of the required data retention period - they were much more used to systems such as payroll & HR where records are only retained for a fixed number of years after the period of employment as demanded by things like the local tax regulations and the idea that due to legal liability, etc., we needed to retain the information for the full life of the product being developed and possibly beyond if components were reused.

Oct 29 2021, 06:55 · Phorge

Oct 17 2021

dcog added a comment to T15006: Re-brand Phorge.
In T15006#1429, @speck wrote:

I can provide more information later this weekend but I think it would help if we set up a virtual meeting with anyone interested in helping to get this done.

Oct 17 2021, 17:13 · Phorge

Oct 16 2021

dcog added a comment to T15006: Re-brand Phorge.

Also this Vagrant pattern should work first-run with vagrant up: https://we.phorge.it/T15027#852

Oct 16 2021, 04:08 · Phorge

Oct 5 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I'm down to do a https://meet.jit.si/ with someone else who is also down for this idea as well as the idea of translatable generic confirm() and alert() dialogs that can trivially go from pht() in PHP to JavaScript. Anyone?

Oct 5 2021, 03:43 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

We can have a i18n option for both confirmDialog and alertDialog.... Let's do this, who is down?

Oct 5 2021, 03:38 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#793, @dcog wrote:
In D25015#792, @dcog wrote:

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

One thing to note here: Native JavaScript blocks execution when these functions are used. This is apparently nearly impossible behavior to mimic exactly, but we can solve this with asynchronous functions with our generic and platform-specific confirm() and alert() functions. Otherwise, should there be an always-available global translation for both alert() and confirm()?

Example of custom confirm():

JX.confirm({
  message: "Form data may have changed. Are you sure you want to close this dialog?",
  buttonConfirm: "Discard Changes",
  buttonCancel: "Cancel",
  onConfirm: function() {
    // Something something
  }
});

But it would need translation added...

Oct 5 2021, 03:37 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#792, @dcog wrote:

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

One thing to note here: Native JavaScript blocks execution when these functions are used. This is apparently nearly impossible behavior to mimic exactly, but we can solve this with asynchronous functions with our generic and platform-specific confirm() and alert() functions. Otherwise, should there be an always-available global translation for both alert() and confirm()?

Oct 5 2021, 03:36 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

Oct 5 2021, 03:35 · Maniphest

Sep 17 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

What if, to get this functionality pushed through, we for now change the verbiage to two English words -- "Discard changes?"

Sep 17 2021, 02:17 · Maniphest
dcog added a comment to T15010: Vision Statement.

Any chance that anyone has insight on D25015? Specifically, a way to get l18n (internationalization/translation) information from PHP into JavaScript from a minimalist approach

Sep 17 2021, 00:14 · Phorge, Governance
dcog added a comment to T15010: Vision Statement.

Really glad to see Phabricator will live on - I've previously managed some bugfixes in an external repo and would love to try to get them into upstream. I've run Phabricator instances for 7 of the last 9 years (and was unable to convince my previous employer to switch) so I've got a bit of experience on the managing side as well.

Sep 17 2021, 00:11 · Phorge, Governance

Sep 13 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Dug up some more info as well...

Sep 13 2021, 20:29 · Maniphest

Sep 4 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#678, @speck wrote:

It looks like there is a JX.phtize() which appears to be used to create a function that mimics pht() in JavaScript but I believe requires that whatever is passed to phtize() is effectively a map of translations which is presumably passed from the server somewhere. I've not yet uncovered this later part.

Sep 4 2021, 22:28 · Maniphest

Aug 24 2021

dcog added a comment to T15016: Update default storage namespace.

Does anyone like, not like, or have additional thoughts on the general idea of making one or more unique identifiers that isn't "phorge", for the purpose of an identifier that is unmistakably greppable? I outlined some notes on this idea here: T15006#831

Aug 24 2021, 08:59 · Phorge General/Unknown

Aug 19 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Also I don’t believe javelin.io is related to the Javalin used in Phab.

Aug 19 2021, 05:45 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Oh, another potential concern...

Aug 19 2021, 04:34 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#616, @speck wrote:

In this case I think the error text is agnostic of the instance of the dialog. From looking at AphrontDialogView I didn't see any obvious way to include additional fields/text that could be pulled out here on the front end. Looking elsewhere in this file (line ~297) it looks like some other generic text is used

if (!this._paused) {
  JX.$E('Resuming a workflow which is not paused!');
}

However that's the only case where JX.$E is used outside of an is-development check. I'm not sure where these Javascript translations would go or when the translation file is generated.

Aug 19 2021, 04:33 · Maniphest

Jul 28 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I 100% agree with this. Is there no way to invoke internationalization via JS only? If not, that's perfectly great, but wondering about an answer offhand.

Jul 28 2021, 06:40 · Maniphest

Jul 26 2021

dcog added a comment to T15010: Vision Statement.

I would like to be a part of the core team, and I've signed the document.

Jul 26 2021, 04:29 · Phorge, Governance

Jul 25 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

On a related note, tonight I discovered this UIExamples application (changing links from my Vagrant install):

Jul 25 2021, 04:07 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#532, @speck wrote:

It’s generally more clear to have the buttons read “Discard changes” vs. “Ok” or “Yes”

I agree

Would it be easy to change the prompt to be more descriptive with actions?

For me, I think it might be on the hard side... and maybe add some bloat? Unless there is a styled generic confirm box created that maybe uses a callback instead of blocks execution...

Jul 25 2021, 03:30 · Maniphest
dcog updated the summary of D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 25 2021, 03:02 · Maniphest
Ekubischta awarded D25015: Show confirmation dialog when closing a modal if form contents have been changed a Like token.
Jul 25 2021, 02:55 · Maniphest

Jul 24 2021

dcog requested review of D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 24 2021, 06:55 · Maniphest
dcog updated the task description for T15034: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 24 2021, 06:47 · Maniphest
dcog created T15034: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 24 2021, 06:47 · Maniphest

Jul 18 2021

dcog added a comment to T15030: Support a Phorge Extensions ecosystem.
In T15030#972, @avivey wrote:

A space-zombie game that can report high-scores to IRC, Slack and Phorge.

Jul 18 2021, 07:06 · Phorge

Jul 16 2021

dcog added a comment to T15014: Develop a Phorge Release Process.
In T15014#929, @avivey wrote:

nit-pick: maybe name them phabricator/master and phabricator/stable

Jul 16 2021, 01:21 · Phorge
dcog added a comment to T15030: Support a Phorge Extensions ecosystem.
In T15030#949, @0 wrote:

There are some projects listed on the Phabricator Community Resources page. Would all of those be eligible for hosting here, or would there be some criteria to limit the number of external projects?

Jul 16 2021, 01:17 · Phorge

Jul 13 2021

dcog added a comment to T15030: Support a Phorge Extensions ecosystem.
In T15030#915, @avivey wrote:

I'm thinking of hosting them here, giving each project to manage their own repositories, but having a more tight control over the creation of the repo (for technical reasons) and projects.
I'd like to only have projects that are clearly related to Phorge in the install, because we're not GitHub.

Having individual git repos also matches the common way extensions are installed (and my drafts for arc-install-eztension)

Jul 13 2021, 06:37 · Phorge
dcog added a comment to T15030: Support a Phorge Extensions ecosystem.
In T15030#914, @avivey wrote:

We are planning on hosting community-driven extensions/projects (temp codename "Phactory"), either here or in a different domain; the idea is to have each project maintain their own repositories.

Jul 13 2021, 06:35 · Phorge
dcog added a comment to T15030: Support a Phorge Extensions ecosystem.

Found that SVN works great for a monorepo... Does Mercurial as well?

Jul 13 2021, 03:22 · Phorge
dcog added a comment to T15027: Build a VM-based developer environment.

Confirmed working fine in both Windows 10 and Linux Mint 20

Jul 13 2021, 03:10 · Phorge General/Unknown

Jul 7 2021

dcog added a comment to T15027: Build a VM-based developer environment.

Here is a proof-of-concept for a Vagrant pattern.

Jul 7 2021, 21:47 · Phorge General/Unknown
dcog added a comment to T15006: Re-brand Phorge.

Actually here is where that particular library is registered: https://we.phorge.it/source/phorge/browse/master/src/__phutil_library_init__.php$3

Jul 7 2021, 19:47 · Phorge
dcog added a comment to T15006: Re-brand Phorge.
In T15006#849, @avivey wrote:

TBH, I'm a little confused about the way forward here, and I think this our biggest blocker?
I have some time I can put towards this, but I'm not sure what I should be doing.

Jul 7 2021, 19:40 · Phorge
dcog added a comment to T15006: Re-brand Phorge.
In T15006#839, @speck wrote:

I think in the case of email headers we would want to duplicate the headers to allow sites migrating time to update their dependence on the existing email headers -- so duplicate the headers to include both X-Phabricator-XYZ and X-Phorge-XYZ, then in a year or so remove X-Phabricator-XYZ. I'm not sure if HTTP headers would be used the same way and might be possible to change those without a migration period.

Jul 7 2021, 08:09 · Phorge
speck awarded T15027: Build a VM-based developer environment a Like token.
Jul 7 2021, 03:00 · Phorge General/Unknown
dcog added a comment to T15006: Re-brand Phorge.
In T15006#279, @avivey wrote:
  • Emails have a bunch of X-Phabricator-* headers, for configuring rules in mail clients.

I don't know how often they are used (GMail doesn't support rules based on headers), but we may want to allow installs to keep it as Phabricator for compatibility.

Jul 7 2021, 00:38 · Phorge

Jul 6 2021

dcog added a comment to T15026: Create a migration guide to move from Phabricator to Phorge.

Added related task T15006 since it could likely serve as a reference for this one... Please undo or stop me if I'm overstepping boundaries

Jul 6 2021, 22:35 · Phorge
dcog added a parent task for T15026: Create a migration guide to move from Phabricator to Phorge: T15006: Re-brand Phorge.
Jul 6 2021, 22:33 · Phorge
dcog added a subtask for T15006: Re-brand Phorge: T15026: Create a migration guide to move from Phabricator to Phorge.
Jul 6 2021, 22:33 · Phorge
dcog created T15027: Build a VM-based developer environment.
Jul 6 2021, 22:05 · Phorge General/Unknown
dcog added a comment to T15011: Build a Phorge Developer Environment.

I actually started on a VSCode Devcontainer based solution on my GitHub: https://github.com/willson556/phorge-devcontainer

Jul 6 2021, 19:55 · Phorge General/Unknown
dcog added a comment to T15011: Build a Phorge Developer Environment.

I want to also mention on this topic... Using a pre-packaged VirtualBox image can be a straightforward distribution route, with a drawback being filesize... Perhaps Torrents could be a neat way alternative to distribute something like that, though there would be a few options including sponsored mirrors, etc... VirtualBox is a common Vagrant provider, so oftentimes it is a prerequisite anyway...

Jul 6 2021, 18:07 · Phorge General/Unknown
dcog added a comment to T15011: Build a Phorge Developer Environment.

We should consider a Vagrantfile

Jul 6 2021, 16:34 · Phorge General/Unknown
dcog added a comment to T15026: Create a migration guide to move from Phabricator to Phorge.

For projects that were tracking upstream previously and able to merge, would this not be a matter of a Git config update to add or swap remotes then merge?

Jul 6 2021, 16:31 · Phorge